Build: Remove pom exclusions hack used for gradle 2.13 #23809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we are on gradle 3.3, we can take advantage of a fix that was made in 2.14 which properly handles disabling transitive dependencies in pom generation. As it was currently, we actually ended up generated two exclusions sections in the generated pom. This is yet another example of why we need validation on the pom files with our generation here, but I leave that for another day because I still don't know a good way to do it.
rjernst
changed the title
rjernst
added a commit
that referenced
this pull request
Mar 30, 2017
Now that we are on gradle 3.3, we can take advantage of a fix that was made in 2.14 which properly handles disabling transitive dependencies in pom generation. As it was currently, we actually ended up generated two exclusions sections in the generated pom. This is yet another example of why we need validation on the pom files with our generation here, but I leave that for another day because I still don't know a good way to do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we are on gradle 3.3, we can take advantage of a fix that was
made in 2.14 which properly handles disabling transitive dependencies in
pom generation. As it was currently, we actually ended up generated two
exclusions sections in the generated pom. This is yet another example of
why we need validation on the pom files with our generation here, but I
leave that for another day because I still don't know a good way to do
it.