Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engine: version logic on replicas should not be hard coded #23998

Merged
merged 2 commits into from
Apr 9, 2017
Merged

Engine: version logic on replicas should not be hard coded #23998

merged 2 commits into from
Apr 9, 2017

Commits on Apr 9, 2017

  1. Engine: version logic on replicas should be hard coded 

    The refactoring in elastic#23711 hardcoded version logic for replica to assume monotonic versions. Sadly that's
wrong for `FORCE` and `VERSION_GTE`. Instead we should use the methods in VersionType to detect conflicts.

Note - once replicas use sequence numbers for out of order delivery, this logic goes away.
    @bleskes
    bleskes committed Apr 9, 2017
    Configuration menu
    Copy the full SHA
    2aef7e4 View commit details
    Browse the repository at this point in the history

  2. feedback

    @bleskes
    bleskes committed Apr 9, 2017
    Configuration menu
    Copy the full SHA
    3150353 View commit details
    Browse the repository at this point in the history