Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote replica on the highest version node #25277

Merged
merged 11 commits into from
Jun 29, 2017
Merged

Promote replica on the highest version node #25277

merged 11 commits into from
Jun 29, 2017

Commits on Jun 19, 2017

  1. Promote replica on the highest version node 

    This changes the replica selection to prefer to return replicas on the highest
version when choosing a replacement to promote when the primary shard fails.

Consider this situation:

- A replica on a 5.6 node
- Another replica on a 6.0 node
- The primary on a 6.0 node

The primary shard is sending sequence numbers to the replica on the 6.0 node and
skipping sending them for the 5.6 node. Now assume that the primary shard fails
and (prior to this change) the replica on 5.6 node gets promoted to primary, it
now has no knowledge of sequence numbers and the replica on the 6.0 node will be
expecting sequence numbers but will never receive them.

Relates to elastic#10708
    @dakrone
    dakrone committed Jun 19, 2017
    Configuration menu
    Copy the full SHA
    3aa3edc View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2017

  1. Switch from map of node to version to retrieving the version from the… 

    … node
    @dakrone
    dakrone committed Jun 20, 2017
    Configuration menu
    Copy the full SHA
    1273e99 View commit details
    Browse the repository at this point in the history

  2. Remove uneeded null check

    @dakrone
    dakrone committed Jun 20, 2017
    Configuration menu
    Copy the full SHA
    879eef0 View commit details
    Browse the repository at this point in the history

  3. You can pretend you're a functional language Java, but you're not foo… 

    …ling me.
    @dakrone
    dakrone committed Jun 20, 2017
    Configuration menu
    Copy the full SHA
    cb42f65 View commit details
    Browse the repository at this point in the history

  4. Randomize node versions

    @dakrone
    dakrone committed Jun 20, 2017
    Configuration menu
    Copy the full SHA
    54edaf8 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2017

  1. Add test with random cluster state with multiple versions that fails … 

    …shards
    @dakrone
    dakrone committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    ef8c79d View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2017

  1. Re-add comment and remove extra import

    @dakrone
    dakrone committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    27469f5 View commit details
    Browse the repository at this point in the history

  2. Remove unneeded stuff, randomly start replicas a few more times

    @dakrone
    dakrone committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    4da03ea View commit details
    Browse the repository at this point in the history

  3. Move test into FailedNodeRoutingTests

    @dakrone
    dakrone committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    56dfe80 View commit details
    Browse the repository at this point in the history

  4. Make assertions actually test replica version promotion

    @dakrone
    dakrone committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    3ca757b View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2017

  1. Rewrite test, taking Yannick's feedback into account

    @dakrone
    dakrone committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    9d9d4b7 View commit details
    Browse the repository at this point in the history