Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapses package structure for some bucket aggs #25579

Merged
merged 2 commits into from
Jul 10, 2017
Merged

Collapses package structure for some bucket aggs #25579

merged 2 commits into from
Jul 10, 2017

Conversation

colings86
Copy link
Contributor

This change collapses some of the packages for the bucket aggregations into their parent packages. This was done for the following aggregations:

  • The variants of the range aggregation (geo_distance, date and ip) were moved into the o.e.s.a.bucket.range package
  • The o.e.s.a.bucket.terms.support package was removed and the classes were moved to o.e.s.a.bucket.terms
  • The filter aggregation was moved to o.e.s.a.bucket.filter

Since this PR is already relatively large with only the above changes subsequent PRs will do similar operations on relevant metric and pipeline aggregations

Relates to #22868

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM maybe add a note to the migrate guide, as this breaks existing users code (thinking of the high level client and people migrating from 5.6 to 6.0)?

This change collapses some of the packages for the bucket aggregations into their parent packages. This was done for the following aggregations:
* The variants of the range aggregation (geo_distance, date and ip) were moved into the `o.e.s.a.bucket.range` package
* The `o.e.s.a.bucket.terms.support` package was removed and the classes were moved to `o.e.s.a.bucket.terms`
* The filter aggregation was moved to `o.e.s.a.bucket.filter`

Since this PR is already relatively large with only the above changes subsequent PRs will do similar operations on relevant metric and pipeline aggregations

Relates to #22868
@colings86 colings86 merged commit 3a5a54e into elastic:master Jul 10, 2017
@colings86 colings86 deleted the fix/22868 branch July 10, 2017 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants