Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes FieldStats API #25628

Merged
merged 3 commits into from
Jul 13, 2017
Merged

Removes FieldStats API #25628

merged 3 commits into from
Jul 13, 2017

Conversation

colings86
Copy link
Contributor

@colings86 colings86 commented Jul 10, 2017 •
edited
Loading

Closes #25577

@colings86 colings86 requested a review from jimczi July 10, 2017 10:38
@colings86 colings86 added :Search/Search Search-related issues that do not fall into other categories >breaking review v6.0.0 labels Jul 10, 2017
@colings86 colings86 self-assigned this Jul 10, 2017
jimczi
jimczi approved these changes Jul 10, 2017
View reviewed changes
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s1monw
Copy link
Contributor

s1monw commented Jul 13, 2017

@colings86 @jimczi @clintongormley I think we can merge this now given elastic/kibana#12814 and #25658 /cc @epixa @spalger ?

@colings86
Copy link
Contributor Author

@s1monw agreed, I just rebased to fix a merge conflict so as soon as the build passes I'll merge this

@s1monw
Copy link
Contributor

s1monw commented Jul 13, 2017

@colings86 lets wait for thumbs-up from @epixa or @spalger

@colings86
Copy link
Contributor Author

ok will do

@epixa
Copy link
Contributor

epixa commented Jul 13, 2017

Thanks

Thumbs up

@colings86 colings86 merged commit 11477a6 into elastic:master Jul 13, 2017
@colings86 colings86 deleted the remove/fieldStatsAPI branch July 13, 2017 10:56
@colings86
Copy link
Contributor Author

Thanks @epixa, this is now merged into master 😄

@weltenwort weltenwort mentioned this pull request Aug 15, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimczi jimczi jimczi approved these changes

Assignees

@colings86 colings86

Labels
>breaking :Search/Search Search-related issues that do not fall into other categories v6.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@colings86 @s1monw @epixa @jimczi @clintongormley