Throw correct exception when looking for discovery module #2635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we should put both classnames we try to load into the error message to prevent any confusion here? I agree we should include the last exception but I think it makes sense to have the short name in there as well? This is usually thrown on startup so we should be super verbose, no? |
|
ah yeah I guess you are right... I will merge this soon. |
|
pushed to master - thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently throws the ClassNotFoundException from the original module loading attempt (something unhelpful like "ec2") instead of the fully qualified class ES looks for in the end (i.e. "org.elasticsearch.discovery.ec2.Ec2DiscoveryModule")
Helped me debug classloader issues with OSGI.