Remove checkpoint tracker bit sets setting #27191
Conversation
We added an index-level setting for controlling the size of the bit sets used to back the local checkpoint tracker. This setting is really only needed to control the memory footprint of the bit sets but we do not think this setting is going to be needed. This commit removes this setting before it is released to the wild after which we would have to worry about BWC implications.
|
I'm not marking this as a non-issue because this is technically a breaking change between the 6.0.0 pre-releases and 6.0.0 GA. I am not marking this as breaking since we do not offer BWC guarantees between pre-releases and GA. |
|
test this please |
1 similar comment
|
test this please |
| SequenceNumbers.NO_OPS_PERFORMED, | ||
| SequenceNumbers.NO_OPS_PERFORMED | ||
| ); | ||
| return new LocalCheckpointTracker(SequenceNumbers.NO_OPS_PERFORMED, SequenceNumbers.NO_OPS_PERFORMED); |
There was a problem hiding this comment.
Wait - I think we need to allow testing it with a small value - to make sure multiple arrays are used? I was thinking of adding a (protected/package private/whatever) constructor.
There was a problem hiding this comment.
I think we had a miscommunication, which we have now clarified via another channel. I have pushed so that we test with a lot of operations to cover the default size of the bit sets we are using now, as opposed to the small size that we were using before.
|
@bleskes Can you review again? |
|
retest this please |
We added an index-level setting for controlling the size of the bit sets used to back the local checkpoint tracker. This setting is really only needed to control the memory footprint of the bit sets but we do not think this setting is going to be needed. This commit removes this setting before it is released to the wild after which we would have to worry about BWC implications. Relates #27191
We added an index-level setting for controlling the size of the bit sets used to back the local checkpoint tracker. This setting is really only needed to control the memory footprint of the bit sets but we do not think this setting is going to be needed. This commit removes this setting before it is released to the wild after which we would have to worry about BWC implications. Relates #27191
clintongormley
added
:Distributed/Engine
We added an index-level setting for controlling the size of the bit sets used to back the local checkpoint tracker. This setting is really only needed to control the memory footprint of the bit sets but we do not think this setting is going to be needed. This commit removes this setting before it is released to the wild after which we would have to worry about BWC implications.
Relates #10708, relates #27179