Validate op_type for _create
#27483
Merged
Validate op_type for _create
#27483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
s1monw
requested changes
Nov 21, 2017
| request.params().put("op_type", "create"); | ||
| return RestIndexAction.this.prepareRequest(request, client); | ||
| } | ||
|
|
||
| public void validateOpType(String opType) { | ||
| if (null != opType && !"create".equals(opType.toLowerCase(Locale.US))) { |
There was a problem hiding this comment.
also please use == false for comparison
There was a problem hiding this comment.
@s1monw I just made the requested changes.
|
@elasticmachine ok to test |
s1monw
approved these changes
Nov 22, 2017
| request.params().put("op_type", "create"); | ||
| return RestIndexAction.this.prepareRequest(request, client); | ||
| } | ||
|
|
||
| public void validateOpType(String opType) { |
There was a problem hiding this comment.
maybe make this static and pkg private?
There was a problem hiding this comment.
@s1monw what about private (or pkg private) and final?
It cannot be set to static as the inner class CreateHandler itself is not static.
olcbean
force-pushed
the
check_op_type
branch
from
9ac5312
to
7a2a35a
Compare
s1monw
added
:Core/Infra/REST API
|
merged thanks |
martijnvg
added a commit
that referenced
this pull request
Nov 24, 2017
* es/master: (38 commits) Backport wait_for_initialiazing_shards to cluster health API Carry over version map size to prevent excessive resizing (#27516) Fix scroll query with a sort that is a prefix of the index sort (#27498) Delete shard store files before restoring a snapshot (#27476) Replace `delimited_payload_filter` by `delimited_payload` (#26625) CURRENT should not be a -SNAPSHOT version if build.snapshot is false (#27512) Fix merging of _meta field (#27352) Remove unused method (#27508) unmuted test, this has been fixed by #27397 Consolidate version numbering semantics (#27397) Add wait_for_no_initializing_shards to cluster health API (#27489) [TEST] use routing partition size based on the max routing shards of the second split Adjust CombinedDeletionPolicy for multiple commits (#27456) Update composite-aggregation.asciidoc Deprecate `levenstein` in favor of `levenshtein` (#27409) Automatically prepare indices for splitting (#27451) Validate `op_type` for `_create` (#27483) Minor ShapeBuilder cleanup muted test Decouple nio constructs from the tcp transport (#27484) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently any
op_typepassed to_createis simply set tocreatewithout any validation.This PR will validate the passed
op_typeto_createas discussed in commentCC @javanna