Reject setting index.optimize_auto_generated_id after version 7.0.0 #28895

liketic · 2018-03-04T08:39:58Z

Do not allow modify setting index.optimize_auto_generated_id after version 7.0.

Relates to #27600

elasticmachine · 2018-03-04T08:40:00Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

elasticmachine · 2018-03-04T08:40:00Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

jasontedor

I left a comment about the location of the test.

jasontedor · 2018-03-04T16:24:47Z

server/src/test/java/org/elasticsearch/index/engine/EngineConfigTests.java

+import org.elasticsearch.test.IndexSettingsModule;
+
+
+public class EngineConfigTests extends ESTestCase {


I do not think we need a new class for this. Maybe there is an existing class where this would be appropriate?

Thanks @jasontedor , how about elasticsearch/server/src/test/java/org/elasticsearch/index/engine/InternalEngineTests.java or elasticsearch/server/src/test/java/org/elasticsearch/index/engine/InternalEngineSettingsTests.java ?

That sounds better.

I moved the test to InternalEngineTests.java. I'm not sure if it's appropriate. Please review again, thanks!

elasticmachine · 2018-04-24T08:38:40Z

Pinging @elastic/es-core-infra

javanna · 2018-05-07T12:31:22Z

Review comment seems to have been addressed, @jasontedor would you mind having another look?

jasontedor · 2018-05-25T02:21:27Z

@liketic The change looks good; can you merge master and resolve conflicts and we can integrate this?

liketic · 2018-05-26T02:07:41Z

Thanks @jasontedor , please review again.

jasontedor · 2018-06-03T17:22:10Z

@elasticmachine test this please

javanna · 2018-08-16T13:47:35Z

@jasontedor does it make sense to try and resurrect this one together with #28862?

jasontedor · 2018-12-11T14:44:23Z

@liketic Can you bring this PR up to date with master? I tried to merge master in and didn't merge cleanly.

liketic · 2018-12-13T15:35:50Z

Thanks @jasontedor , please review again.

jasontedor

I left a comment. Let me know if you need a pointer to the right place to reject this setting.

jasontedor · 2018-12-20T16:34:59Z

server/src/main/java/org/elasticsearch/index/engine/EngineConfig.java

@@ -126,6 +127,11 @@ public EngineConfig(ShardId shardId, String allocationId, ThreadPool threadPool,
                        List<ReferenceManager.RefreshListener> internalRefreshListener, Sort indexSort,
                        CircuitBreakerService circuitBreakerService, LongSupplier globalCheckpointSupplier,
                        LongSupplier primaryTermSupplier, TombstoneDocSupplier tombstoneDocSupplier) {
+        if (indexSettings.getIndexVersionCreated().onOrAfter(Version.V_7_0_0)


I think this is too late to be rejecting this setting. It means the index will already be created and in the cluster state, but all shards will fail during engine creation. The user will be left with a red index.

Thanks. I moved to createIndexService. Could you please review again?

* master: (1159 commits) Fix timezone fallback in ingest processor (elastic#38407) Avoid polluting download stats on builds (elastic#38660) SQL: Prevent grouping over grouping functions (elastic#38649) SQL: Relax StackOverflow circuit breaker for constants (elastic#38572) [DOCS] Fixes broken migration links (elastic#38655) Drop support for the low-level REST client on JDK 7 (elastic#38540) [DOCS] Adds placeholders for v8 highlights, breaking changes, release notes (elastic#38641) fix dissect doc "ip" --> "clientip" (elastic#38545) Concurrent file chunk fetching for CCR restore (elastic#38495) make DateMathIndexExpressionsIntegrationIT more resilient (elastic#38473) SQL: Replace joda with java time (elastic#38437) Add fuzziness example (elastic#37194) (elastic#38648) Mute AnalysisModuleTests#testStandardFilterBWC (elastic#38636) add geotile_grid ref to asciidoc (elastic#38632) Enable Dockerfile from artifacts.elastic.co (elastic#38552) Mute FollowerFailOverIT testFailOverOnFollower (elastic#38634) Account for a possible rolled over file while reading the audit log file (elastic#34909) Mute failure in InternalEngineTests (elastic#38622) Fix Issue with Concurrent Snapshot Init + Delete (elastic#38518) Refactor ZonedDateTime.now in millis resolution (elastic#38577) ...

jasontedor · 2019-02-10T14:18:51Z

@elasticmachine test this please

This commit rejects the index.optmize_auto_generated_id setting for indices created on or after 7.0.0. This setting was deprecated in 6.7.0.

Reject setting index.optimize_auto_generated_id after version 7.0.0 (e…

2c7fe6a

…lastic#27583)

liketic mentioned this pull request Mar 4, 2018

Remove setting index.optimize_auto_generated_id (#27583) #27600

Merged

jasontedor self-requested a review March 4, 2018 16:15

jasontedor requested changes Mar 4, 2018

View reviewed changes

Move test to existing class

7276da9

colings86 added :Data Management/Indices APIs APIs to create and manage indices and templates >deprecation labels Apr 24, 2018

javanna added the review label May 7, 2018

Resolve conflicts

e8e4ca5

rjernst removed the review label Oct 10, 2018

liketic added 2 commits December 13, 2018 23:30

Merge master

b36c840

Fix tests

a21095e

jasontedor requested changes Dec 20, 2018

View reviewed changes

liketic added 2 commits December 23, 2018 22:26

Reject index setting when creating index

c225cc8

Remove test

2aec530

danielmitterdorfer added the v7.0.0 label Jan 11, 2019

danielmitterdorfer mentioned this pull request Jan 11, 2019

Remove index.optimize_auto_generated_id #27583

Closed

jasontedor added v8.0.0 v7.2.0 labels Feb 10, 2019

jasontedor merged commit fe5bdb4 into elastic:master Feb 10, 2019

jasontedor pushed a commit that referenced this pull request Feb 10, 2019

Reject index.optimize_auto_generated_id setting (#28895)

b8be6cb

This commit rejects the index.optmize_auto_generated_id setting for indices created on or after 7.0.0. This setting was deprecated in 6.7.0.

jasontedor pushed a commit that referenced this pull request Feb 10, 2019

Reject index.optimize_auto_generated_id setting (#28895)

97b64ee

This commit rejects the index.optmize_auto_generated_id setting for indices created on or after 7.0.0. This setting was deprecated in 6.7.0.

jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 12, 2019

jakelandis added v8.0.0-alpha1 and removed v8.0.0 labels Jul 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reject setting index.optimize_auto_generated_id after version 7.0.0 #28895

Reject setting index.optimize_auto_generated_id after version 7.0.0 #28895

liketic commented Mar 4, 2018

elasticmachine commented Mar 4, 2018

elasticmachine commented Mar 4, 2018

jasontedor left a comment

jasontedor Mar 4, 2018

liketic Mar 5, 2018 •

edited

Loading

jasontedor Mar 8, 2018

liketic Mar 12, 2018

elasticmachine commented Apr 24, 2018

javanna commented May 7, 2018

jasontedor commented May 25, 2018

liketic commented May 26, 2018

jasontedor commented Jun 3, 2018

javanna commented Aug 16, 2018 •

edited

Loading

jasontedor commented Dec 11, 2018

liketic commented Dec 13, 2018

jasontedor left a comment

jasontedor Dec 20, 2018

liketic Dec 23, 2018

jasontedor commented Feb 10, 2019

		import org.elasticsearch.test.IndexSettingsModule;


		public class EngineConfigTests extends ESTestCase {

Reject setting index.optimize_auto_generated_id after version 7.0.0 #28895

Reject setting index.optimize_auto_generated_id after version 7.0.0 #28895

Conversation

liketic commented Mar 4, 2018

elasticmachine commented Mar 4, 2018

elasticmachine commented Mar 4, 2018

jasontedor left a comment

Choose a reason for hiding this comment

jasontedor Mar 4, 2018

Choose a reason for hiding this comment

liketic Mar 5, 2018 • edited Loading

Choose a reason for hiding this comment

jasontedor Mar 8, 2018

Choose a reason for hiding this comment

liketic Mar 12, 2018

Choose a reason for hiding this comment

elasticmachine commented Apr 24, 2018

javanna commented May 7, 2018

jasontedor commented May 25, 2018

liketic commented May 26, 2018

jasontedor commented Jun 3, 2018

javanna commented Aug 16, 2018 • edited Loading

jasontedor commented Dec 11, 2018

liketic commented Dec 13, 2018

jasontedor left a comment

Choose a reason for hiding this comment

jasontedor Dec 20, 2018

Choose a reason for hiding this comment

liketic Dec 23, 2018

Choose a reason for hiding this comment

jasontedor commented Feb 10, 2019

liketic Mar 5, 2018 •

edited

Loading

javanna commented Aug 16, 2018 •

edited

Loading