Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Get Settings API support to java high-level rest client #29229

Merged
merged 15 commits into from
May 4, 2018
Merged

Add Get Settings API support to java high-level rest client #29229

merged 15 commits into from
May 4, 2018

Commits on Apr 17, 2018

  1. Add Get Settings API support to java high-level rest client

    @tomcallahan
    tomcallahan committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    a0210d4 View commit details
    Browse the repository at this point in the history

  2. Fix bad import style in GetSettingsResponse.java

    @tomcallahan
    tomcallahan committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    74185c1 View commit details
    Browse the repository at this point in the history

  3. Consolidate much of the get_settings logic inside of the tranpsort la… 

    …yer, moving logic from the rest layer

Expand transport protocol to include defaults start with version 7
Add tests to ensure transport protocol backwards compatibility
    @tomcallahan
    tomcallahan committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    8e1eba2 View commit details
    Browse the repository at this point in the history

  4. fix a few minor nits

    @tomcallahan
    tomcallahan committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    a7e87c5 View commit details
    Browse the repository at this point in the history

  5. incorporate PR feedback

    @tomcallahan
    tomcallahan committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    745813d View commit details
    Browse the repository at this point in the history

  6. address reviewer feedback

    @tomcallahan
    tomcallahan committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    906b32a View commit details
    Browse the repository at this point in the history

  7. make parsing forward compatible

    @tomcallahan
    tomcallahan committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    39a1640 View commit details
    Browse the repository at this point in the history

  8. address recent reviewer comments, including removing bad settings dif… 

    …f/filtering logic and adding a unit test for TransportGetSettingsAction
    @tomcallahan
    tomcallahan committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    4632027 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2018

  1. remove extraneous test

    @tomcallahan
    tomcallahan committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    f19c698 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into high-level-rest-get… 

    …-settings
    @tomcallahan
    tomcallahan committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    f661b42 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2018

  1. Merge remote-tracking branch 'origin/master' into high-level-rest-get… 

    …-settings
    @tomcallahan
    tomcallahan committed Apr 20, 2018
    Configuration menu
    Copy the full SHA
    e5b5d0b View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2018

  1. Incorporate reviewer feedback

    @tomcallahan
    tomcallahan committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    e2a592e View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into high-level-rest-get… 

    …-settings
    @tomcallahan
    tomcallahan committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    ccc6a72 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2018

  1. Merge remote-tracking branch 'origin/master' into high-level-rest-get… 

    …-settings
    @tomcallahan
    tomcallahan committed May 2, 2018
    Configuration menu
    Copy the full SHA
    4611fae View commit details
    Browse the repository at this point in the history

  2. fix item missed in merge

    @tomcallahan
    tomcallahan committed May 2, 2018
    Configuration menu
    Copy the full SHA
    cfe8f2e View commit details
    Browse the repository at this point in the history