Deprecate slicing on _uid.
#29353
Merged
Deprecate slicing on _uid.
#29353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`_id` should be used instead on 6.x.
jpountz
added
:Search/Search
|
Pinging @elastic/es-search-aggs |
nik9000
reviewed
Apr 3, 2018
| @@ -91,14 +97,22 @@ public SliceBuilder(String field, int id, int max) { | |||
| } | |||
|
|
|||
| public SliceBuilder(StreamInput in) throws IOException { | |||
| this.field = in.readString(); | |||
| String field = in.readString(); | |||
| if (UidFieldMapper.NAME.equals(field) && in.getVersion().before(Version.V_6_3_0)) { | |||
There was a problem hiding this comment.
I wonder if this is safe?
Like, if you slice on _uid in a mixed version cluster, will this cause you to get duplicate documents and to miss documents?
There was a problem hiding this comment.
I see. You've made it safe below. I think that is worth a comment.
|
@nik9000 I added a comment as you suggested. |
jpountz
added a commit
that referenced
this pull request
Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_idshould be used instead on 6.x.