Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds new installation package details #29590

Merged
merged 11 commits into from
May 2, 2018

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Apr 18, 2018

This PR updates the Elasticsearch Reference with respect to changes in the installation packages.

@lcawl lcawl added >docs General docs changes :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts v7.0.0 v6.3.0 labels Apr 18, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Elasticsearch on any Debian-based system such as Debian and Ubuntu.

This package contains both open source and commercial features.
Copy link
Contributor

@skearns64 skearns64 Apr 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can make it more clear that it's free? The term "commercial features" isn't wrong - the default distribution contains features that aren't under an OSI-approved license - but this phrasing doesn't doesn't send the message that "it's totally free to use, but isn't totally Apache 2.0 licensed." I still struggle with the best way to phrase it here though.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about: "This package contains both open source, free commercial, and paid commercial features"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's definitely an improvement, but I wonder if we need to explicitly highlight the distinction between OSS and "not" AND free and not-free?
Another approach would be to communicate that it's free to use, and that it's not governed by Apache 2.0. What about: "This package is free to use under the Elastic License."?

Copy link

@clintongormley clintongormley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a suggestion

Elasticsearch on any Debian-based system such as Debian and Ubuntu.

This package contains both open source and commercial features.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about: "This package contains both open source, free commercial, and paid commercial features"?

Elasticsearch on any Debian-based system such as Debian and Ubuntu.

This package contains both open source and commercial features.
{xpack-ref}/license-management.html[Start a 30-day trial license] to enable all
of the available commercial features. See the

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the change above, how about:

Start a 30-day trial license to try out all of the paid commercial features.

@lcawl
Copy link
Contributor Author

lcawl commented Apr 19, 2018

Thanks for the feedback! I've updated the text based on suggestions here and in elastic/kibana#17781

Copy link
Contributor

@Sue-Gallagher Sue-Gallagher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pcsanwald pcsanwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about using a fragment for the language around this, it seems useful? Happy to defer to @lcawl 's opinion on this.

Elasticsearch on any Debian-based system such as Debian and Ubuntu.

This package is free to use under the Elastic license. It contains open source
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there is value in having this whole section as a fragment, and including via include::license_stuffs? it might cut down on the number of places to update going forward, if there are links and such we need to change? If done as an include, we could use that include at least 5 times in the files in this PR seemingly?

Everything else LGTM 💯

@lcawl lcawl merged commit fd20370 into elastic:master May 2, 2018
@lcawl lcawl deleted the lcawley-install branch May 2, 2018 00:04
dnhatn added a commit that referenced this pull request May 2, 2018
* 6.x: (62 commits)
  [DOCS] Adds new installation package details (#29590)
  Revert "Build: Move gradle wrapper jar to a dot dir (#30146)"
  [DOCS] Added 6.3.0 section to changelog
  [DOCS] Merge 6.x release notes into changelog (#30312)
  [DOCS] Removes broken link
  [DOCS] Adds file realm configuration details (#30221)
  [DOCS] Adds PKI realm configuration details (#30225)
  [DOCS] Fix 6.4-specific link in changelog (#30314)
  Remove RepositoriesMetaData variadic constructor (#29569)
  [DOCS] Adds changelog to Elasticsearch Reference (#30310)
  Test: increase authentication logging for debugging
  [DOCS] Removes redundant SAML realm settings (#30196)
  SQL: Teach the CLI to ignore empty commands (#30265)
  [DOCS] Fixes section error
  [DOCS] Adds Active Directory realm configuration details (#30223)
  [DOCS] Removes redundant file realm settings (#30192)
  [DOCS] Fixes users command name (#30275)
  Build: Move gradle wrapper jar to a dot dir (#30146)
  Build: Log a warning if disabling reindex-from-old (#30304)
  TEST: Add debug log to FlushIT
  ...
jasontedor added a commit that referenced this pull request May 2, 2018
* master:
  Fix message content in users tool (#30293)
  [DOCS] Fixes links to breaking changes
  [DOCS] Adds new installation package details (#29590)
  Revert "Build: Move gradle wrapper jar to a dot dir (#30146)"
@bleskes bleskes added v6.3.0 and removed v6.3.1 labels May 3, 2018
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts >docs General docs changes Team:Delivery Meta label for Delivery team v6.3.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants