-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more contexts to painless execute api #30511
Merged
martijnvg
merged 16 commits into
elastic:master
from
martijnvg:painless_execute_api_add_more_contexts
Jul 18, 2018
Merged
Changes from 3 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
3e78138
[Painless] Add more contexts to painless execute api
martijnvg e86764a
added tests and docs, changed the parsing code to make more use of Ob…
martijnvg d965597
changed PainlessExecuteAction.TransportAction to use TransportSingleS…
martijnvg 636ad34
Merge remote-tracking branch 'es/master' into painless_execute_api_ad…
martijnvg 539abde
rename
martijnvg 7bc755c
fixed typo
martijnvg 65bbaf8
added unit like tests and made the code easier to test
martijnvg f82c307
Merge remote-tracking branch 'es/master' into painless_execute_api_ad…
martijnvg fd3fb41
Use ScoreScript instead of SearchScript (see #30816)
martijnvg caf6f26
fixed docs
martijnvg 6da0dc7
fixed docs for real
martijnvg e3437cf
Merge remote-tracking branch 'es/master' into painless_execute_api_ad…
martijnvg 95300fe
iter
martijnvg f3eab3f
introduced context_setup parameter
martijnvg 3afa5d0
made context setup fields final
martijnvg 9b3b67e
Merge remote-tracking branch 'es/master' into painless_execute_api_ad…
martijnvg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is quite confusing using "context" here, since for scripts, context is something different. It would be really good if we had a different term for this environment the script runs in...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, I will rename it to
execute_script_context
. (after the ExecuteScriptContext class)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed it to
execute_context
(the script part sounded redundant to me): 539abde