Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept Gradle build scan agreement #30645

Merged
merged 4 commits into from
May 22, 2018
Merged

Accept Gradle build scan agreement #30645

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f62a860
Accept Gradle build scan argreement
alpar-t May 14, 2018
ec1ecda
Merge commit '9be3fbd1b20' into build/scan
alpar-t May 18, 2018
cbed215
Condition TOS acceptance with property
alpar-t May 18, 2018
b29f345
Switch to boolean flags
alpar-t May 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,16 @@ import java.nio.file.Files
import java.nio.file.Path
import java.security.MessageDigest

plugins {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: please add a newline between here and the imports

id 'com.gradle.build-scan' version '1.13.2'
}
if (properties.get("org.elasticsearch.scanTOS", "no") == "agree") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should yes true/false here, not "no" and "agree".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjernst done

buildScan {
termsOfServiceUrl = 'https://gradle.com/terms-of-service'
termsOfServiceAgree = 'yes'
}
}

// common maven publishing configuration
subprojects {
group = 'org.elasticsearch'
Expand Down