Delay _uid field data deprecation warning #30651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A deprecation warning is printed when creating the fieldddata builder for the `_uid` field. This change moves the deprecation logging to the building of the fielddata since otherwise APIs like `_field_caps` can emit deprecation warning when they just test the capabilities of the `_uid` field. Closes elastic#30625
jimczi
added
>bug
:Search Foundations/Mapping
|
Pinging @elastic/es-search-aggs |
jpountz
approved these changes
May 16, 2018
jimczi
added a commit
that referenced
this pull request
May 16, 2018
A deprecation warning is printed when creating the fieldddata builder for the `_uid` field. This change moves the deprecation logging to the building of the fielddata since otherwise APIs like `_field_caps` can emit deprecation warning when they just test the capabilities of the `_uid` field. Closes #30625
martijnvg
added a commit
that referenced
this pull request
May 17, 2018
* es/6.x: (44 commits) SQL: Remove dependency for server's version from JDBC driver (#30631) Make xpack modules instead of a meta plugin (#30589) Security: Remove SecurityLifecycleService (#30526) Build: Add task interdependencies for ssl configuration (#30633) Mute ShrinkIndexIT [ML] DeleteExpiredDataAction should use client with origin (#30646) Reindex: Fixed typo in assertion failure message (#30619) [DOCS] Fixes list of unconverted snippets in build.gradle Use readFully() to read bytes from CipherInputStream (#30640) Add Create Repository High Level REST API (#30501) [DOCS] Reorganizes RBAC documentation Test: increase search logging for LicensingTests Delay _uid field data deprecation warning (#30651) Deprecate Empty Templates (#30194) Remove unused DirectoryUtils class. (#30582) Mitigate date histogram slowdowns with non-fixed timezones. (#30534) [TEST] Remove AwaitsFix in IndicesOptionsTests#testSerialization S3 repo plugin populates SettingsFilter (#30652) Rest High Level client: Add List Tasks (#29546) Fixes IndiceOptionsTests to serialise correctly (#30644) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A deprecation warning is printed when creating the fieldddata builder for the
_uidfield.This change moves the deprecation logging to the building of the fielddata since otherwise
APIs like
_field_capscan emit deprecation warning when they just test the capabilitiesof the
_uidfield.Closes #30625