Add more script contexts #30721
Merged
Add more script contexts #30721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
>non-issue
review
:Core/Infra/Scripting
|
Pinging @elastic/es-core-infra |
rjernst
approved these changes
May 18, 2018
| public static final ScriptContext<Factory> SCRIPT_SORT_CONTEXT = new ScriptContext<>("script_sort", Factory.class); | ||
| // Can return a float | ||
| public static final ScriptContext<Factory> SCRIPT_SCORE_CONTEXT = new ScriptContext<>("script_score", Factory.class); |
There was a problem hiding this comment.
Can we call this just score? I've been trying to give the script context identifiers names that don't include "script" since that is implicit.
| // Can return a double. (For ScriptSortType#NUMBER only, for ScriptSortType#STRING normal CONTEXT should be used) | ||
| public static final ScriptContext<Factory> SCRIPT_SORT_CONTEXT = new ScriptContext<>("script_sort", Factory.class); |
There was a problem hiding this comment.
Here too, can use just "sort" for the context name?
rjernst
reviewed
May 18, 2018
| public static final ScriptContext<Factory> SCRIPT_SCORE_CONTEXT = new ScriptContext<>("script_score", Factory.class); | ||
| // Can return a long | ||
| public static final ScriptContext<Factory> TERMS_SET_QUERY_CONTEXT = new ScriptContext<>("terms_set_query", Factory.class); |
There was a problem hiding this comment.
Maybe this can just be "terms_set" too
Added dedicated script contexts for: * script function score * script sorting * terms_set query Scripts for these contexts will either have a specific return value or use scoring and therefor in the future will need their own scripting classes. Relates to elastic#30511
martijnvg
force-pushed
the
more_script_contexts
branch
from
5910349
to
888dbf3
Compare
|
Thanks for reviewing and follow ups are needed to make specialised contexts. |
martijnvg
added a commit
that referenced
this pull request
May 20, 2018
Added dedicated script contexts for: * script function score * script sorting * terms_set query Scripts for these contexts will either have a specific return value or use scoring and therefor in the future will need their own scripting classes. Relates to #30511
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
May 21, 2018
…ne-liners * elastic/master: [TEST] Enable DEBUG logging on testAutoQueueSizingWithMax [ML] Don't install empty ML metadata on startup (elastic#30751) Add assertion on removing copy_settings (elastic#30748) bump lucene version for 6_3_0 [DOCS] Mark painless execute api as experimental (elastic#30710) disable annotation processor for docs (elastic#30610) Add more script contexts (elastic#30721) Fix default shards count in create index docs (elastic#30747)
dnhatn
added a commit
that referenced
this pull request
May 21, 2018
* master: Reduce CLI scripts to one-liners (#30759) SQL: Preserve scoring in bool queries (#30730) QA: Switch rolling upgrade to 3 nodes (#30728) [TEST] Enable DEBUG logging on testAutoQueueSizingWithMax [ML] Don't install empty ML metadata on startup (#30751) Add assertion on removing copy_settings (#30748) bump lucene version for 6_3_0 [DOCS] Mark painless execute api as experimental (#30710) disable annotation processor for docs (#30610) Add more script contexts (#30721) Fix default shards count in create index docs (#30747) Mute testCorruptFileThenSnapshotAndRestore
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
May 22, 2018
* es/ccr: (50 commits) Reduce CLI scripts to one-liners (elastic#30759) SQL: Preserve scoring in bool queries (elastic#30730) QA: Switch rolling upgrade to 3 nodes (elastic#30728) [TEST] Enable DEBUG logging on testAutoQueueSizingWithMax [ML] Don't install empty ML metadata on startup (elastic#30751) Add assertion on removing copy_settings (elastic#30748) bump lucene version for 6_3_0 [DOCS] Mark painless execute api as experimental (elastic#30710) disable annotation processor for docs (elastic#30610) Add more script contexts (elastic#30721) Fix default shards count in create index docs (elastic#30747) Mute testCorruptFileThenSnapshotAndRestore Scripting: Remove getDate methods from ScriptDocValues (elastic#30690) Upgrade to Lucene-7.4.0-snapshot-59f2b7aec2 (elastic#30726) [Docs] Fix single page :docs:check invocation (elastic#30725) Docs: Add uptasticsearch to list of clients (elastic#30738) [DOCS] Removes out-dated x-pack/docs/en/index.asciidoc [DOCS] Removes redundant index.asciidoc files (elastic#30707) [TEST] Reduce forecast overflow to disk test memory limit (elastic#30727) Plugins: Remove meta plugins (elastic#30670) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added dedicated script contexts for:
Scripts for these contexts will either have a specific return value or
use scoring and therefor in the future will need their own scripting classes.
Spin off from #30511