[CCR] Refactor ChunksCoordinator to continuously look for changes in leader shard #30898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
review
:Distributed/CCR
|
Pinging @elastic/es-distributed |
* A single ChunksCoordinator is now in charge of following a shard and keeps on coordinating until the persistent task has been stopped. Whereas before a ChunksCoordinator's job was to process a finite amount of chunks and then a new ChunksCoordinator instance would process the next chunks. * Instead of consuming the chunks queue and waiting for all workers to complete, another background thread will continuously and chunks to the queue, so that the workers never run out of chunks to process if the leader shard has unprocessed write operations. Relates to elastic#30086
martijnvg
force-pushed
the
background_chunks_update_task
branch
from
1868897
to
4e84a95
Compare
martijnvg
force-pushed
the
background_chunks_update_task
branch
from
add7759
to
b378c4a
Compare
|
I've been running the benchmark (http logs) and with this change the follow index caught almost immediately after indexing has been completed. Whereas before it could take up between 5 and 10 minutes before the follow index had all the changes from the leader index. I'll continue to test with the other new ccr benchmarks. |
|
I also tested with both pmc and geopoints benchmarks and in both cases after the benchmark data was indexed in the leader index, the follower index had all the documents within seconds. |
|
Superseded by: #31581 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make ChunksCoordinator in full control of following leader shard:
keeps on coordinating until the persistent task has been stopped. Whereas
before a ChunksCoordinator's job was to process a finite amount of chunks
and then a new ChunksCoordinator instance would process the next chunks.
complete, another background thread will continuously and chunks to the
queue, so that the workers never run out of chunks to process if the
leader shard has unprocessed write operations.
Relates to #30086