Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML][TEST] Mute tests using rules #31204

Merged
merged 2 commits into from
Jun 12, 2018
Merged

[ML][TEST] Mute tests using rules #31204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58caa58
[ML][TEST] Mute tests using rules
dimitris-athanasiou Jun 8, 2018
4de4447
Use @AwaitsFix instead of @Ignore
dimitris-athanasiou Jun 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...l-native-tests/src/test/java/org/elasticsearch/xpack/ml/integration/DetectionRulesIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import org.elasticsearch.xpack.core.ml.job.config.RuleConditionType;
import org.elasticsearch.xpack.core.ml.job.results.AnomalyRecord;
import org.junit.After;
import org.junit.Ignore;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer needed


import java.io.IOException;
import java.util.ArrayList;
Expand Down Expand Up @@ -51,6 +52,7 @@ public void cleanUpTest() throws Exception {
cleanUp();
}

@AwaitsFix(bugUrl = "this test is muted temporarily until the new rules implementation is merged in")
public void testNumericalRule() throws Exception {
RuleCondition condition1 = RuleCondition.createNumerical(
RuleConditionType.NUMERICAL_ACTUAL,
Expand Down Expand Up @@ -152,6 +154,7 @@ public void testNumericalRule() throws Exception {
assertThat(secondHaldRecordByFieldValues, contains("by_field_value_1", "by_field_value_2"));
}

@AwaitsFix(bugUrl = "this test is muted temporarily until the new rules implementation is merged in")
public void testCategoricalRule() throws Exception {
MlFilter safeIps = new MlFilter("safe_ips", Arrays.asList("111.111.111.111", "222.222.222.222"));
assertThat(putMlFilter(safeIps), is(true));
Expand Down
4 changes: 4 additions & 0 deletions ...-native-tests/src/test/java/org/elasticsearch/xpack/ml/integration/ScheduledEventsIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import org.elasticsearch.xpack.core.ml.job.results.AnomalyRecord;
import org.elasticsearch.xpack.core.ml.job.results.Bucket;
import org.junit.After;
import org.junit.Ignore;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer needed


import java.io.IOException;
import java.time.Instant;
Expand All @@ -41,6 +42,7 @@ public void cleanUpTest() {
cleanUp();
}

@AwaitsFix(bugUrl = "this test is muted temporarily until the new rules implementation is merged in")
public void testScheduledEvents() throws IOException {

TimeValue bucketSpan = TimeValue.timeValueMinutes(30);
Expand Down Expand Up @@ -152,6 +154,7 @@ public void testScheduledEvents() throws IOException {
assertThat(records, is(empty()));
}

@AwaitsFix(bugUrl = "this test is muted temporarily until the new rules implementation is merged in")
public void testScheduledEventWithInterimResults() throws IOException {
TimeValue bucketSpan = TimeValue.timeValueMinutes(30);
Job.Builder job = createJob("scheduled-events-interim-results", bucketSpan);
Expand Down Expand Up @@ -193,6 +196,7 @@ public void testScheduledEventWithInterimResults() throws IOException {
/**
* Test an open job picks up changes to scheduled events/calendars
*/
@AwaitsFix(bugUrl = "this test is muted temporarily until the new rules implementation is merged in")
public void testOnlineUpdate() throws Exception {
TimeValue bucketSpan = TimeValue.timeValueMinutes(30);
Job.Builder job = createJob("scheduled-events-online-update", bucketSpan);
Expand Down