Add put stored script support to high-level rest client #31323

johnny94 · 2018-06-14T08:47:42Z

This adds support for the put stored script API to the high level rest client.

Relates to #27205

vladimirdolzhenko

Thank you @johnny94 so much for you code - I really depend on it (for get script and delete script parts). I left couple comments for structural improvement.

vladimirdolzhenko · 2018-06-14T09:07:26Z

client/rest-high-level/src/main/java/org/elasticsearch/client/IndicesClient.java

+     * @return the response
+     * @throws IOException in case there is a problem sending the request or parsing back the response
+     */
+    public PutStoredScriptResponse putStoredScript(PutStoredScriptRequest putStoredScriptRequest,


this API call doesn't belong to any category and is described at https://github.com/elastic/elasticsearch/blob/master/rest-api-spec/src/main/resources/rest-api-spec/api/put_script.json - and it looks like it has to go to main RestHighLevelClient ( e.g. in comparison to https://github.com/elastic/elasticsearch/blob/master/rest-api-spec/src/main/resources/rest-api-spec/api/indices.create.json that is for category indices)

Could you please move those methods to RestHighLevelClient ?

can you also remove the stored part from the method names?

should I also remove the stored parts from the class names?

no those have to stay as they are as it's already existing classes that people have been using with the transport client.

vladimirdolzhenko · 2018-06-14T09:09:00Z

client/rest-high-level/src/test/java/org/elasticsearch/client/IndicesClientIT.java

+        PutStoredScriptRequest request = new PutStoredScriptRequest()
+            .id("script1");
+
+        try (XContentBuilder builder = XContentBuilder.builder(xContentType.xContent())) {


It would be great to encapsulate all that in PutStoredScriptRequest.toXContent(XContentBuilder builder, Params params)

vladimirdolzhenko · 2018-06-14T09:10:12Z

...level/src/test/java/org/elasticsearch/client/documentation/IndicesClientDocumentationIT.java

+        }
+
+        {
+            PutStoredScriptRequest request = new PutStoredScriptRequest();


same - pls move it to PutStoredScriptRequest.toXContent(XContentBuilder builder, Params params)

@vladimirdolzhenko Thanks for your advice. But I am curious about that is it necessary to move the code to PutStoredScriptRequest.toXContent(XContentBuilder builder, Params params). I found there are lots of test code written like this.

And as far as I know, toXContent will build a XContentBuilder object based on the content of a request, and it will be used in RequestConverters. So I am not really sure how to put this into PutStoredScriptRequest.toXContent. If you have any idea how to do that, please let me know and I will fix this as soon as possible. Thanks!

Sorry, my fault - I thought there is a method to set source directly - you've already added PutStoredScriptRequest.toXContent that creates nested script object with source itself - so that part is good.

vladimirdolzhenko · 2018-06-14T09:11:03Z

...level/src/test/java/org/elasticsearch/client/documentation/IndicesClientDocumentationIT.java

+                new ActionListener<PutStoredScriptResponse>() {
+                    @Override
+                    public void onResponse(PutStoredScriptResponse response) {
+                        // <1>


i'd rather prefer to store response in some kind of ref and to check it after that

nevermind - the same style is used in other documentation examples

vladimirdolzhenko · 2018-06-14T09:18:14Z

client/rest-high-level/src/test/java/org/elasticsearch/client/IndicesClientIT.java

@@ -1201,4 +1205,31 @@ public void testGetIndexTemplate() throws Exception {
            new GetIndexTemplatesRequest().names("the-template-*"), client.indices()::getTemplate, client.indices()::getTemplateAsync));
        assertThat(notFound.status(), equalTo(RestStatus.NOT_FOUND));
    }
+
+    public void testPutStoredScript() throws Exception {


I think the same applicable for tests for this REST API call - RestHighLevelClientTests is better place for it as this call doesn't belong to any category

Maybe it is a good idea to move putStoredScript to other place, but I am not really sure whether RestHighLevelClient is a good place or not.

But according to #27205 it seems that script API should be categorized as Indices API. I am confused...

good point...

in fact in #27205 it is under indices api while rest api spec says it's out of any category...

in my PR #31355 I put them into StoredScriptsIT - to group them reasonably...

@javanna do you have any objections / concerns / suggestion ?

RestHighLevelClientTests is a unit test while this is an integ test, adding them to a new StoredScriptsIT sounds good to me. I will move the API to the right category in the meta issue, it should not be under indices, the transport client even exposed it up until now under cluster, but we should follow our rest spec so we are aligned with the other language clients.

and I assume the same is applicable for StoredScriptsDocumentationIT

yes that sounds good too

johnny94 · 2018-06-14T13:20:49Z

@vladimirdolzhenko Thanks for your comments! I will make some changes based on your comment.

elasticmachine · 2018-06-15T06:15:10Z

Pinging @elastic/es-core-infra

javanna

left some comments too, thanks @johnny94 !

javanna · 2018-06-15T14:57:30Z

client/rest-high-level/src/main/java/org/elasticsearch/client/IndicesClient.java

+     * @return the response
+     * @throws IOException in case there is a problem sending the request or parsing back the response
+     */
+    public PutStoredScriptResponse putStoredScript(PutStoredScriptRequest putStoredScriptRequest,


can you also remove the stored part from the method names?

javanna · 2018-06-15T14:58:31Z

client/rest-high-level/src/main/java/org/elasticsearch/client/RequestConverters.java

+        Params params = new Params(request);
+        params.withTimeout(putStoredScriptRequest.timeout());
+        params.withMasterTimeout(putStoredScriptRequest.masterNodeTimeout());
+        request.setEntity(createEntity(putStoredScriptRequest, REQUEST_BODY_CONTENT_TYPE));


don't we also support a context parameter?

sorry for asking that, I do not really understand what does context mean here. After searching documentation I only found two docs:

https://www.elastic.co/guide/en/elasticsearch/painless/master/painless-execute-api.html
https://www.elastic.co/guide/en/elasticsearch/reference/master/modules-scripting-security.html

where should I put the parameter?

don't be sorry, I can explain! at REST, we also accept the context query_string parameter. It is a string and PutStoredScriptRequest already supports it, you just have to read it from the request and set the corresponding parameter so that we pass it through to the REST layer.

javanna · 2018-06-15T15:10:36Z

client/rest-high-level/src/test/java/org/elasticsearch/client/RequestConvertersTests.java

+
+        Map<String, String> expectedParams = new HashMap<>();
+        setRandomMasterTimeout(putStoredScriptRequest, expectedParams);
+        setRandomTimeout(putStoredScriptRequest::timeout, AcknowledgedRequest.DEFAULT_ACK_TIMEOUT, expectedParams);


here we should test the context param too?

javanna · 2018-06-15T15:12:20Z

docs/java-rest/high-level/indices/put_storedscript.asciidoc

+include-tagged::{doc-tests}/IndicesClientDocumentationIT.java[put-stored-script-content-mustache]
+--------------------------------------------------
+<1> Specify a mustache script and provided as `XContentBuilder` object.
+Note that value of source can be direvtly provided as a JSON string


javanna · 2018-06-15T15:12:24Z

docs/java-rest/high-level/indices/put_storedscript.asciidoc

+include-tagged::{doc-tests}/IndicesClientDocumentationIT.java[put-stored-script-content-painless]
+--------------------------------------------------
+<1> Specify a painless script and provided as `XContentBuilder` object.
+Note that the builder need to be passed as a `BytesReference` object


javanna · 2018-06-15T15:12:58Z

docs/java-rest/high-level/indices/put_storedscript.asciidoc

+<1> Specify a mustache script and provided as `XContentBuilder` object.
+Note that value of source can be direvtly provided as a JSON string
+
+[[java-rest-high-put-stored-script-sync]]


I think that we need to add the Optional parameters section with the 3 optional parameters that are supported

Does this mean context, xContentType and source in PutStoredScriptRequest class?

more like context, and the two timeouts.

javanna · 2018-06-15T15:20:05Z

...c/main/java/org/elasticsearch/action/admin/cluster/storedscripts/PutStoredScriptRequest.java

+
+    @Override
+    public XContentBuilder toXContent(XContentBuilder builder, Params params) throws IOException {
+        if (source == null) {


when is this if exercised? I think that you can make the blank constructor package protected and assume that once toXContent is called the source has already a value. that has the nice effect that we don't modify the state of the request when toXContent is called which is not ideal.

javanna · 2018-06-15T15:20:45Z

...c/main/java/org/elasticsearch/action/admin/cluster/storedscripts/PutStoredScriptRequest.java

@@ -166,4 +168,16 @@ public String toString() {
            (context != null ? ", context [" + context + "]" : "") +
            ", content [" + source + "]}";
    }
+
+    @Override
+    public XContentBuilder toXContent(XContentBuilder builder, Params params) throws IOException {


given that you added this method, I would also add a unit test for it. I would probably also move the respective parsing code from RestPutStoredScriptAction here as a fromXContent method so that testing is also easier.

can you add a unit test for this method please?

I was trying to find a better way to add a unit test for this method. After reading some classes I found that those classes which have toXContent method also have assertToXContentBody assertion. so I add something like that in RequestConvertersTests.java

https://github.com/johnny94/elasticsearch/blob/82a8611fa631d4b4d9d0b25e011a2900c5674443/client/rest-high-level/src/test/java/org/elasticsearch/client/RequestConvertersTests.java#L2092

Is this a proper way to test the code?

that is part of it, but it only tests that the client takes the request body into account and prints it out. It would also be nice to add a test to the server-side code, which verifies the output itself. We usually do this by adding a request test. You can just add a new testToXContent method to PutStoredScriptRequestTests which tests the xcontent output. Something static (not randomized) is fine for this type of test.

Thanks for your hint! I added a test for the method.

vladimirdolzhenko · 2018-06-19T12:32:58Z

@johnny94 would you be so kind as well to merge master and adjust

elasticsearch/client/rest-high-level/src/test/java/org/elasticsearch/client/StoredScriptsIT.java

Line 53 in 04e4e44

// TODO: change to HighLevel PutStoredScriptRequest when it will be ready

and

elasticsearch/client/rest-high-level/src/test/java/org/elasticsearch/client/StoredScriptsIT.java

Line 79 in 04e4e44

// TODO: change to HighLevel PutStoredScriptRequest when it will be ready

with your HL REST API part ?

johnny94 · 2018-06-19T12:41:44Z

@vladimirdolzhenko Of course! Thanks for your contribution!

…ests its test.

johnny94 · 2018-06-20T16:54:42Z

@javanna
Thanks for your comments, I have fixed some issues. Could you plz have another look into this?

vladimirdolzhenko

thanks @johnny94 for the change - a left few minor comments

vladimirdolzhenko · 2018-06-21T10:08:51Z

client/rest-high-level/src/main/java/org/elasticsearch/client/RequestConverters.java

+        Params params = new Params(request);
+        params.withTimeout(putStoredScriptRequest.timeout());
+        params.withMasterTimeout(putStoredScriptRequest.masterNodeTimeout());
+        if(Strings.hasText(putStoredScriptRequest.context())){


minor - spaces between if and (Strings, and space between ){ at the end of line

vladimirdolzhenko · 2018-06-21T10:11:04Z

client/rest-high-level/src/test/java/org/elasticsearch/client/StoredScriptsIT.java

-
-        GetStoredScriptRequest getRequest = new GetStoredScriptRequest("calculate-score");
+        PutStoredScriptRequest request =
+            new PutStoredScriptRequest(id, "search", new BytesArray("{}"), XContentType.JSON, scriptSource);


vladimirdolzhenko · 2018-06-21T10:12:03Z

client/rest-high-level/src/test/java/org/elasticsearch/client/StoredScriptsIT.java

+            new PutStoredScriptRequest(id, "search", new BytesArray("{}"), XContentType.JSON, scriptSource);
+        PutStoredScriptResponse putResponse = execute(request, highLevelClient()::putScript,
+            highLevelClient()::putScriptAsync);
+        assertThat(putResponse.isAcknowledged(), equalTo(true));


recently I learnt about assertAcked - you can easily use it (and inline putResponse there as well)

vladimirdolzhenko · 2018-06-21T10:13:22Z

client/rest-high-level/src/test/java/org/elasticsearch/client/StoredScriptsIT.java

+            new PutStoredScriptRequest(id, "search", new BytesArray("{}"), XContentType.JSON, scriptSource);
+        PutStoredScriptResponse putResponse = execute(request, highLevelClient()::putScript,
+            highLevelClient()::putScriptAsync);
+        assertThat(putResponse.isAcknowledged(), equalTo(true));


same - assertAcked

vladimirdolzhenko · 2018-06-21T10:19:40Z

...level/src/test/java/org/elasticsearch/client/documentation/StoredScriptsDocumentationIT.java

+        RestHighLevelClient client = highLevelClient();
+
+        {
+            createIndex("index1", Settings.EMPTY);


no need to create any index for stored scripts

vladimirdolzhenko · 2018-06-21T10:21:33Z

docs/java-rest/high-level/script/put_script.asciidoc

+include-tagged::{doc-tests}/StoredScriptsDocumentationIT.java[put-stored-script-request]
+--------------------------------------------------
+<1> The id of the script
+<2> The content of the script


couple missed optional properties of request - master_timeout and timeout

Thanks. I have added this two arguments in Optional arguments section.

javanna · 2018-06-27T10:47:23Z

test this please

vladimirdolzhenko

@johnny94 thanks, it looks good - agree with @javanna - PutStoredScriptRequestTests has to be added - you already did PutStoredScriptResponseTests - but it is quite simple one, you can have a look to another existed tests

vladimirdolzhenko · 2018-06-28T08:46:10Z

client/rest-high-level/src/main/java/org/elasticsearch/client/RestHighLevelClient.java

@@ -712,6 +714,35 @@ public void deleteScriptAsync(DeleteStoredScriptRequest request, RequestOptions
            DeleteStoredScriptResponse::fromXContent, listener, emptySet());
    }

+    /**
+     * Puts an stored script using the Scripting API.
+     * See <a href="https://www.elastic.co/guide/en/elasticsearch/reference/6.2/modules-scripting.html"> Scripting API


pls refer to current instead of 6.2: https://www.elastic.co/guide/en/elasticsearch/reference/current/modules-scripting.html

vladimirdolzhenko · 2018-06-28T08:48:08Z

client/rest-high-level/src/main/java/org/elasticsearch/client/RestHighLevelClient.java

+
+    /**
+     * Asynchronously puts an stored script using the Scripting API.
+     * See <a href="https://www.elastic.co/guide/en/elasticsearch/reference/6.2/modules-scripting.html"> Scripting API


same here - pls refer to current

johnny94 · 2018-07-05T06:25:23Z

sorry for tagging again @vladimirdolzhenko @javanna Could have a look into this again? If it okay to both of you, I am planning to fix file conflicts.

vladimirdolzhenko

thanks @johnny94 for the update - you should not apologize. There is a recommendation for the test class improvement.

I see you did change a week ago - and nobody had a look into your changes - sorry.

I'd like to ask you just ping reviewers with a comment and/or assign reviewer for the review again - in this case we do receive notification.

vladimirdolzhenko · 2018-07-05T06:50:53Z

...t/java/org/elasticsearch/action/admin/cluster/storedscripts/PutStoredScriptRequestTests.java

@@ -48,4 +51,30 @@ public void testSerialization() throws IOException {
            }
        }
    }
+
+    public void testToXContent() throws IOException {


it would be reasonable PutStoredScriptRequestTests to extend AbstractStreamableXContentTestCase<PutStoredScriptRequest> - it gives more randomization and general test flow for requests/responses - like you do for PutStoredScriptResponseTests

Thanks for your comment. But I don't know the comment for ping reviewers. Is there any documentation about this? Or could you help me to assign reviewer for the review again... Thanks!

@johnny94 I meant to leave a comment like hey @reviewer - could you pls have a look

johnny94 · 2018-07-11T03:09:53Z

@javanna Could you plz have a look into this again? If it looks good to you, I will fix conflicts.

vladimirdolzhenko

@johnny94 look good - the last resort is left as I already mentioned - it would be reasonable to extend PutStoredScriptRequestTests (to extend AbstractStreamableXContentTestCase - it gives more randomization and general test flow for requests/responses - like you do for PutStoredScriptResponseTests)

johnny94 · 2018-07-20T10:20:16Z

@vladimirdolzhenko Thanks for your comment, but I found that most of the test classes ( XXXRequestTest )in the same package extends ESTestCase. (Also GetStoredScriptRequestTests) Maybe it is okay to keep using ESTestCase for now.

And @javanna I have fixed conflict.

vladimirdolzhenko · 2018-07-21T11:55:05Z

@johnny94 I would like to recommend to have a look for the functionality of tests for other requests - more coverage is definitely better - that's why I think it is worth to extend test.

johnny94 · 2018-07-23T09:07:16Z

@vladimirdolzhenko When I trying to extends AbstractStreamableXContentTestCase I have to override number of methods. I am wondering how to override doParseInstance.

@Override
protected PutStoredScriptRequest doParseInstance(XContentParser parser) throws IOException {
  return new PutStoredScriptRequest("bar", "context", new BytesArray("{}"), XContentType.JSON,
            StoredScriptSource.fromXContent(parser, false));
}

This the method I wrote, and I got a test failure said that must specify lang for stored script. This is because it is necessary to specify lang and source when creating StoredScriptSource. I think I missed something when I wrote the method. Could you give me a hint about how to create PutStoredScriptRequest by this method?

vladimirdolzhenko · 2018-07-25T08:00:41Z

@johnny94 I assume it has to be smth like

@Override
protected PutStoredScriptRequest doParseInstance(XContentParser parser) throws IOException {
  return PutStoredScriptRequest.fromXContent(parser);
}

all tests those extend AbstractStreamableXContentTestCase have similar doParseInstance

Hope it helps you.

vladimirdolzhenko · 2018-09-06T12:44:07Z

@johnny94 you've already done a lot - have you faced any difficulties with this ticket - can I help you with smth ?

johnny94 · 2018-09-06T15:06:11Z

@vladimirdolzhenko Thanks for your kind message. I found it is not just to simply extend test class then all things work well. Do you have any idea about how to extends AbstractStreamableXContentTestCase correctly?

vladimirdolzhenko · 2018-09-06T15:50:07Z

sorry for misleading you @johnny94 - PutStoredScriptRequest is not required to be parsable with XContentParser as other parameters are coming outside of xcontent body.

vladimirdolzhenko · 2018-09-06T15:51:02Z

client/rest-high-level/src/test/java/org/elasticsearch/client/RequestConvertersTests.java

+        setRandomMasterTimeout(putStoredScriptRequest, expectedParams);
+        setRandomTimeout(putStoredScriptRequest::timeout, AcknowledgedRequest.DEFAULT_ACK_TIMEOUT, expectedParams);
+
+        if(randomBoolean()) {


nit: space between if and (

vladimirdolzhenko · 2018-09-09T11:31:49Z

thanks @johnny94 LGTM

Relates to #27205 (cherry picked from commit 9073dbe)

* master: CORE: Make Pattern Exclusion Work with Aliases (elastic#33518) Reverse logic for CCR license checks (elastic#33549) Add latch countdown on failure in CCR license tests (elastic#33548) HLRC: Add put stored script support to high-level rest client (elastic#31323) Create temporary directory if needed in CCR test Add license checks for auto-follow implementation (elastic#33496) Bootstrap a new history_uuid when force allocating a stale primary (elastic#33432) INGEST: Remove Outdated TODOs (elastic#33458) Logging: Clean up skipping test Logging: Skip test if it'd fail CRUD: AwaitsFix entire wait_for_refresh close test Painless: Add Imported Static Method (elastic#33440)

Add put stored script support to high-level rest client

9d06e09

vladimirdolzhenko requested review from vladimirdolzhenko and javanna June 14, 2018 09:04

vladimirdolzhenko reviewed Jun 14, 2018

View reviewed changes

vladimirdolzhenko suggested changes Jun 14, 2018

View reviewed changes

colings86 added >enhancement :Core/Java High Level REST Client labels Jun 15, 2018

johnny94 force-pushed the hlrc-put-stored-script-api branch from 38a9eae to a02ba46 Compare June 15, 2018 07:56

fix documentation test error

f9da579

johnny94 force-pushed the hlrc-put-stored-script-api branch from a02ba46 to f9da579 Compare June 15, 2018 08:33

javanna mentioned this pull request Jun 15, 2018

Java high-level REST client completeness #27205

Closed

80 tasks

javanna requested changes Jun 15, 2018

View reviewed changes

fix typo in documentation; Add 'context' parameter for RequestConvert…

a3fa752

…ests its test.

johnny94 force-pushed the hlrc-put-stored-script-api branch from 2c956ca to a3fa752 Compare June 19, 2018 14:30

fix conflict

09be31d

johnny94 force-pushed the hlrc-put-stored-script-api branch from 7e84a14 to 16d5449 Compare June 19, 2018 17:18

Merge script related code

dd3bd38

johnny94 force-pushed the hlrc-put-stored-script-api branch from 16d5449 to dd3bd38 Compare June 20, 2018 16:52

vladimirdolzhenko suggested changes Jun 21, 2018

View reviewed changes

johnny94 added 2 commits June 27, 2018 15:38

Fix conflict

27dccd1

Use assertAcked for checking isAcknowledged response

82a8611

vladimirdolzhenko suggested changes Jun 28, 2018

View reviewed changes

johnny94 added 2 commits June 28, 2018 18:23

add unit test for toXContent method

3e55b99

fix conflict and link in documentation.

11098dc

vladimirdolzhenko reviewed Jul 5, 2018

View reviewed changes

javanna requested a review from vladimirdolzhenko July 11, 2018 09:04

vladimirdolzhenko suggested changes Jul 11, 2018

View reviewed changes

fix conflict

27a9906

vladimirdolzhenko reviewed Sep 6, 2018

View reviewed changes

fix conflict and remove some useless files.

2488452

vladimirdolzhenko approved these changes Sep 9, 2018

View reviewed changes

vladimirdolzhenko merged commit 9073dbe into elastic:master Sep 9, 2018

vladimirdolzhenko pushed a commit that referenced this pull request Sep 9, 2018

HLRC: Add put stored script support to high-level rest client (#31323)

02ed80f

Relates to #27205 (cherry picked from commit 9073dbe)

vladimirdolzhenko added v7.0.0 v6.5.0 labels Sep 9, 2018

colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

Add put stored script support to high-level rest client #31323

Add put stored script support to high-level rest client #31323

Conversation

johnny94 commented Jun 14, 2018

vladimirdolzhenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vladimirdolzhenko Jun 15, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

johnny94 commented Jun 14, 2018

elasticmachine commented Jun 15, 2018

javanna left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

johnny94 Jun 28, 2018 • edited Loading

Choose a reason for hiding this comment

vladimirdolzhenko commented Jun 19, 2018

johnny94 commented Jun 19, 2018

johnny94 commented Jun 20, 2018

vladimirdolzhenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

javanna commented Jun 27, 2018

vladimirdolzhenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

johnny94 commented Jul 5, 2018

vladimirdolzhenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vladimirdolzhenko Jul 10, 2018 • edited Loading

Choose a reason for hiding this comment

johnny94 commented Jul 11, 2018

vladimirdolzhenko left a comment

Choose a reason for hiding this comment

johnny94 commented Jul 20, 2018

vladimirdolzhenko commented Jul 21, 2018

johnny94 commented Jul 23, 2018

vladimirdolzhenko commented Jul 25, 2018 • edited Loading

vladimirdolzhenko commented Sep 6, 2018

johnny94 commented Sep 6, 2018

vladimirdolzhenko commented Sep 6, 2018

Choose a reason for hiding this comment

vladimirdolzhenko commented Sep 9, 2018

vladimirdolzhenko Jun 15, 2018 •

edited

Loading

johnny94 Jun 28, 2018 •

edited

Loading

vladimirdolzhenko Jul 10, 2018 •

edited

Loading

vladimirdolzhenko commented Jul 25, 2018 •

edited

Loading