Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watcher: Remove cron eval CLI tool in favor of API endpoint #31685

Closed

Conversation

spinscale
Copy link
Contributor

The cron evaluation CLI tool can just be an API. This commit
removes the CLI tool and adds a _xpack/watcher/_croneval REST endpoint
and its corresponding transport action.

The transport action has not implemented any serialization because the
request is always considered local and never sent across the network.

The cron evaluation CLI tool can just be an API. This commit
removes the CLI tool and adds a _xpack/watcher/_croneval REST endpoint
and its corresponding transport action.

The transport action has not implemented any serialization because the
request is always considered local and never sent across the network.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM

@uboness
Copy link
Contributor

uboness commented Jul 3, 2018

+1 on exposing it as API, but why not still keep the cli (change it to use the API), at least until we have a user friendly UI for it in kibana?

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hub-cap
Copy link
Contributor

hub-cap commented Jul 3, 2018

once this API is merged, can you add it to the high level rest client checklist @spinscale ? #29827

@spinscale
Copy link
Contributor Author

@uboness the difference between the CLI tool and the dev-tools output is pretty small in the good case (a JSON list of expressions). Do you reckon that a BWC layer is necessary, which also includes code for JSON parsing, auth/SSL issues, exception handling?

From my point of view the cost of that above code is higher than not keeping a BWC layer and point users to the endpoint and use kibana dev-tools.

@spinscale
Copy link
Contributor Author

@elasticmachine retest this please

@uboness
Copy link
Contributor

uboness commented Jul 10, 2018

From my point of view the cost of that above code is higher than not keeping a BWC layer and point users to the endpoint and use kibana dev-tools.

when are we going to see a tool for it in Kibana? is there an issue open for it? When do we expect it to be available?

@rjernst rjernst removed the review label Oct 10, 2018
@jasontedor jasontedor added v8.0.0 and removed v7.0.0 labels Feb 6, 2019
@spinscale spinscale removed the v8.0.0 label Feb 13, 2019
@spinscale
Copy link
Contributor Author

stale. closing.

@spinscale spinscale closed this Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants