-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watcher: Remove cron eval CLI tool in favor of API endpoint #31685
Conversation
The cron evaluation CLI tool can just be an API. This commit removes the CLI tool and adds a _xpack/watcher/_croneval REST endpoint and its corresponding transport action. The transport action has not implemented any serialization because the request is always considered local and never sent across the network.
Pinging @elastic/es-core-infra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! LGTM
+1 on exposing it as API, but why not still keep the cli (change it to use the API), at least until we have a user friendly UI for it in kibana? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
once this API is merged, can you add it to the high level rest client checklist @spinscale ? #29827 |
@uboness the difference between the CLI tool and the dev-tools output is pretty small in the good case (a JSON list of expressions). Do you reckon that a BWC layer is necessary, which also includes code for JSON parsing, auth/SSL issues, exception handling? From my point of view the cost of that above code is higher than not keeping a BWC layer and point users to the endpoint and use kibana dev-tools. |
@elasticmachine retest this please |
when are we going to see a tool for it in Kibana? is there an issue open for it? When do we expect it to be available? |
stale. closing. |
The cron evaluation CLI tool can just be an API. This commit
removes the CLI tool and adds a _xpack/watcher/_croneval REST endpoint
and its corresponding transport action.
The transport action has not implemented any serialization because the
request is always considered local and never sent across the network.