Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rollup] Move toAggCap() methods out of rollup config objects #32583

Merged

Conversation

tlrx
Copy link
Member

@tlrx tlrx commented Aug 2, 2018

This pull request moves the toAggCap() methods out of the rollup configuration objects. These methods are used in the RollupJobCaps and can be computed there, simplifying the rollup configuration objects.

@tlrx tlrx added review v7.0.0 >refactoring :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data v6.5.0 labels Aug 2, 2018
@tlrx tlrx requested review from polyfractal and jimczi August 2, 2018 12:19
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@tlrx tlrx force-pushed the move-toaggcap-methods-out-of-rollup-config-objects branch from 4368719 to 533d913 Compare August 20, 2018 16:41
@tlrx
Copy link
Member Author

tlrx commented Aug 20, 2018

@polyfractal I fixed the conflicts, can you have another look please? Thanks

Copy link
Contributor

@polyfractal polyfractal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tlrx tlrx force-pushed the move-toaggcap-methods-out-of-rollup-config-objects branch from 533d913 to 200ee45 Compare August 24, 2018 10:40
@tlrx tlrx merged commit 7e5efad into elastic:master Aug 24, 2018
@tlrx tlrx deleted the move-toaggcap-methods-out-of-rollup-config-objects branch August 24, 2018 13:31
@tlrx
Copy link
Member Author

tlrx commented Aug 24, 2018

Thanks @jimczi and @polyfractal

dnhatn added a commit that referenced this pull request Aug 26, 2018
* master:
  Add proxy support to RemoteClusterConnection (#33062)
  TEST: Skip assertSeqNos for closed shards (#33130)
  TEST: resync operation on replica should acquire shard permit (#33103)
  Switch remaining x-pack tests to new style Requests (#33108)
  Switch remaining tests to new style Requests (#33109)
  Switch remaining ml tests to new style Requests (#33107)
  Build: Line up IDE detection logic
  Security index expands to a single replica (#33131)
  HLRC: request/response homogeneity and JavaDoc improvements (#33133)
  Checkstyle!
  [Test] Fix sporadic failure in MembershipActionTests
  Revert "Do NOT allow termvectors on nested fields (#32728)"
  [Rollup] Move toAggCap() methods out of rollup config objects (#32583)
  Fix race condition in scheduler engine test
dnhatn added a commit that referenced this pull request Aug 26, 2018
* 6.x:
  Allow engine to recover from translog upto a seqno (#33032)
  TEST: Skip assertSeqNos for closed shards (#33130)
  TEST: resync operation on replica should acquire shard permit (#33103)
  Add proxy support to RemoteClusterConnection (#33062)
  Build: Line up IDE detection logic
  Security index expands to a single replica (#33131)
  Suppress more tests
  HLRC: request/response homogeneity and JavaDoc improvements (#33133)
  [Rollup] Move toAggCap() methods out of rollup config objects (#32583)
  Muted all these tests due to #33128
  Fix race condition in scheduler engine test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>refactoring :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data v6.5.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants