[Zen2] Add PeerFinder#onFoundPeersUpdated #32939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today the PeerFinder silently updates the set of found peers as new peers are discovered and old ones are disconnected, and elections are scheduled independently of these changes. In fact, it would be better if the election scheduler were only activated on discovery of a quorum of peers. This commit introduces the `onFoundPeersUpdated` method that allows this flow.
DaveCTurner
added
>enhancement
v7.0.0
:Distributed/Cluster Coordination
|
Pinging @elastic/es-distributed |
|
@elasticmachine retest this please |
ywelsch
approved these changes
Aug 20, 2018
| for (final Peer peer : peersByAddress.values()) { | ||
| peer.handleWakeUp(); | ||
| peersRemoved = peer.handleWakeUp() || peersRemoved; |
There was a problem hiding this comment.
another way to write this is to use |= (bit-wise or), see https://docs.oracle.com/javase/specs/jls/se7/html/jls-15.html#jls-15.22.2
There was a problem hiding this comment.
Fun with non-strict || vs strict |. I'd prefer to leave as-is but will add a comment.
61 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today the PeerFinder silently updates the set of found peers as new peers are
discovered and old ones are disconnected, and elections are scheduled
independently of these changes. In fact, it would be better if the election
scheduler were only activated on discovery of a quorum of peers. This commit
introduces the
onFoundPeersUpdatedmethod that allows this flow.