Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watcher: Reload properly on remote shard change #33167

Commits on Aug 27, 2018

  1. Watcher: Reload properly on remote shard change

    When a node dies that carries a watcher shard or a shard is relocated to
    another node, then watcher needs not only trigger a reload on the node
    where the shard relocation happened, but also on other nodes where
    copies of this shard, as different watches may need to be loaded.
    
    This commit takes the change of remote nodes into account by not only
    storing the local shard allocation ids in the WatcherLifeCycleService,
    but storing a list of ShardRoutings based on the local active shards.
    
    This also fixes some tests, which had a wrong assumption. Using
    `TestShardRouting.newShardRouting` in our tests for cluster state
    creation led to the issue of always creating new allocation ids which
    implicitely lead to a reload.
    spinscale committed Aug 27, 2018
    Configuration menu
    Copy the full SHA
    4ab3b77 View commit details
    Browse the repository at this point in the history