Logging: Drop Settings from some logging ctors #33332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drops `Settings` from some logging ctors now that they are no longer needed. This should allow us to stop passing `Settings` around to quite as many places.
nik9000
added
review
:Core/Infra/Logging
|
Pinging @elastic/es-core-infra |
nik9000
commented
Sep 1, 2018
| public static Logger getLogger(Class<?> clazz, Settings settings, ShardId shardId, String... prefixes) { | ||
| return getLogger(clazz, settings, shardId.getIndex(), asArrayList(Integer.toString(shardId.id()), prefixes).toArray(new String[0])); | ||
| public static Logger getLogger(Class<?> clazz, ShardId shardId, String... prefixes) { | ||
| return getLogger(clazz, Settings.EMPTY, |
There was a problem hiding this comment.
I'll make follow up changes that remove the need for Settings.EMPTY eventually.
There was a problem hiding this comment.
They are just needed to make it compile and aren't used.
|
Thanks for reviewing @jasontedor! |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Sep 3, 2018
* master: (197 commits) Prevent NPE parsing the stop datafeed request. (elastic#33347) HLRC: Add ML get overall buckets API (elastic#33297) Core: Fix epoch millis java time formatter (elastic#33302) [Docs] Improve tuning for speed advice (elastic#33315) [Rollup] Fix Caps Comparator to handle calendar/fixed time (elastic#33336) [CI] Mute IndexShardTests#testIndexCheckOnStartup fails elastic#33345 [CI] Mute LuceneChangesSnapshotTests#testUpdateAndReadChangesConcurrently Security for _field_names field should not override field statistics (elastic#33261) Add early termination support to BucketCollector (elastic#33279) Fix extractjar task ci (elastic#33272) Mute testFollowIndexAndCloseNode Logging: Drop Settings from some logging ctors (elastic#33332) HLREST: add update by query API (elastic#32760) TEST: Increase timeout testFollowIndexAndCloseNode (elastic#33333) HLRC: ML Flush job (elastic#33187) HLRC: Adding ML Job stats (elastic#33183) LLREST: Drop deprecated methods (elastic#33223) Mute testSyncerOnClosingShard [DOCS] Moves machine learning APIs to docs folder (elastic#31118) Mute test watcher usage stats output ...
nik9000
added a commit
that referenced
this pull request
Sep 5, 2018
Drops `Settings` from some logging ctors now that they are no longer needed. This should allow us to stop passing `Settings` around to quite as many places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops
Settingsfrom some logging ctors now that they are no longerneeded. This should allow us to stop passing
Settingsaround to quiteas many places.