Implement suggested fix from #30606

[LeeDr]

Fixes: #30606

While setting up my new Windows 10 Pro laptop I took the default path for installing the Java 10 JRE;
"C:\Program Files (x86)\Common Files\Oracle\Java"

I'm running a Kibana script that downloads and starts the latest elasticsearch snapshot but it kept failing with this error;
ERROR \Common was unexpected at this time.

@Dobatymo and @lashchev suggested variations on a fix in #30606. I applied the changes exactly as Lashchev suggested here #30606 (comment)

It resolved this problem for me.

NOTE: In my case, I had the JRE installed to that default path, and although I had the jdk 10 installed, I did not have JAVA_HOME set, so it was using the java executable from the JRE that was in my path var.

If I set my JAVA_HOME variable (my jdk path has no spaces or parenthesis) I can start elasticsearch without this fix. But we should fix this problem since it would a common case for Windows users to download the JRE, take the default installation path, and then try to start Elasticsearch.

[elasticmachine]

Pinging @elastic/es-core-infra

[LeeDr]

@nogginbox This PR (specifically the 2nd commit) does also have those double-quotes removed.

[nogginbox]

@LeeDr really sorry. I did not see that. I somehow copied the code from the first commit only. Thanks for taking the time with me when the problem was PEBKAC.

[LeeDr]

@jasontedor I'm not sure what to do with the failures above. Do I retest? In Kibana we comment "Jenkins test this" to run CI again. Is it the same here?

[pgomulka]

I have managed to reproduce that as well:
steps for me were:

using java from a path with spaces and parenthesis

set JAVA_HOME=C:\Program Files (x86)\Java\jre1.8.0_181 
set PATH=%JAVA_HOME%
bin\elasticsearch.bat

\Java\jre1.8.0_181\bin\java.exe" -cp "!ES_CLASSPATH!" "org.elasticsearch.tools.launchers.TempDirectory""` was unexpected at this time.

that failure is from elasticsearch-env.bat : 60

fixing this as advised

  for /f "tokens=* usebackq" %%a in (`CALL %JAVA% -cp "!ES_CLASSPATH!" "org.elasticsearch.tools.launchers.TempDirectory"`) do set ES_TMPDIR=%%a

will let me to fail in elasticsearch.bat:46 (addressed in this PR)

\Java\jre1.8.0_181\bin\java.exe" -cp "!ES_CLASSPATH!" "org.elasticsearch.tools.launchers.JvmOptionsParser" "!ES_JVM_OPTIONS!" || echo jvm_options_parser_failed"`) was unexpected at this time.

and only then when fixed with the snipped from the PR it will let me start

for /F "usebackq delims=" %%a in (`CALL %JAVA% -cp "!ES_CLASSPATH!" "org.elasticsearch.tools.launchers.JvmOptionsParser" "!ES_JVM_OPTIONS!" ^|^| echo jvm_options_parser_failed`) do set JVM_OPTIONS=%%a

I will update this PR with the fix I needed in elasticserach-env.bat as well

[jasontedor]

@pgomulka Thanks for looking into this. Are the some packaging tests that we can add that fail before these changes, and then pass with the changes that you are suggesting. That is what we should have before pulling this change in, so that we are less likely to continually break in these situations when we do maintenance on these scripts.

[pgomulka]

@jasontedor agree, packaging test would be really useful for this. Will look into adding more scenarios