Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapse package structure for metrics aggs #33463

Merged
merged 3 commits into from
Sep 7, 2018
Merged

Collapse package structure for metrics aggs #33463

merged 3 commits into from
Sep 7, 2018

Conversation

jimczi
Copy link
Contributor

@jimczi jimczi commented Sep 6, 2018

This change collapses all metrics aggregations classes into a single package org.elasticsearch.aggregations.metrics.
It also restricts the visibility of some classes (aggregators and factories) that should not be used outside of the package.

Relates #22868

@jimczi
Collapse package structure for metrics aggs
23c72e5 
This change collapses all metrics aggregations classes into a single package `org.elasticsearch.aggregations.metrics`.
It also restricts the visibility of some classes (aggregators and factories) that should not be used outside of the package.

Relates elastic#22868
@nik9000
Copy link
Member

nik9000 commented Sep 6, 2018 via email

@jimczi jimczi merged commit 79cd638 into elastic:master Sep 7, 2018
@jimczi jimczi deleted the metrics_aggregations_package branch September 7, 2018 08:58
@jimczi
Copy link
Contributor Author

jimczi commented Sep 7, 2018

Thanks @nik9000

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Sep 8, 2018
@jasontedor
Merge branch 'master' into auto-follow-license
00f6480 
* master: (30 commits)
  Include fallback settings when checking dependencies (elastic#33522)
  [DOCS] Fixing formatting issues in breaking changes
  CRUD: Disable wait for refresh tests with delete
  Test: Fix test name (elastic#33510)
  HLRC: split ingest request converters (elastic#33435)
  Logging: Configure the node name when we have it (elastic#32983)
  HLRC: split xpack request converters (elastic#33444)
  HLRC: split watcher request converters (elastic#33442)
  HLRC: add enable and disable user API support (elastic#33481)
  [DOCS] Fixes formatting error
  TEST: Ensure merge triggered in _source retention test (elastic#33487)
  [ML] Add a file structure determination endpoint (elastic#33471)
  HLRC: ML Forecast Job (elastic#33506)
  HLRC: split migration request converters (elastic#33436)
  HLRC: split snapshot request converters (elastic#33439)
  Make Watcher validation message copy/pasteable
  Removes redundant test method in SQL tests (elastic#33498)
  HLRC: ML Post Data (elastic#33443)
  Pass Directory instead of DirectoryService to Store (elastic#33466)
  Collapse package structure for metrics aggs (elastic#33463)
  ...
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
jnguyenx added a commit to jnguyenx/elasticsearch that referenced this pull request May 18, 2020
@jnguyenx
Update min-aggregation.asciidoc
e477b27 
The package changed in elastic#33463
jnguyenx added a commit to jnguyenx/elasticsearch that referenced this pull request May 18, 2020
@jnguyenx
Update max-aggregation.asciidoc
3ab9458 
The package changed in elastic#33463
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
>breaking-java >non-issue v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimczi @nik9000