add elasticsearch-shard tool to 6.x #33848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirdolzhenko
added
>enhancement
:Distributed/Store
|
Pinging @elastic/es-distributed |
Relates elastic#31389 (cherry picked from commit a3e8b83)
vladimirdolzhenko
force-pushed
the
fix/31389_2_6x
branch
from
db668ec
to
f2570f4
Compare
DaveCTurner
approved these changes
Sep 21, 2018
There was a problem hiding this comment.
LGTM. Needs to go in with or after the backport of #33911 to avoid introducing this test failure in 6.x, and please could the commit message be the same as the one that went into master?
|
thanks @DaveCTurner, waiting for CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #32281 to
6.xNote: I'd prefer to create another PR as it was couple merge conflict and it is not a small change
Relates #31389