Tests: Add support for custom contexts to mock scripts #34100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the ability to plug in compilation of custom contexts in mock script engine. This is needed for testing plugins which add custom contexts like watcher.
rjernst
added
>enhancement
:Delivery/Build
|
Pinging @elastic/es-core-infra |
|
@elasticmachine test this please |
martijnvg
reviewed
Sep 27, 2018
| import org.elasticsearch.xpack.watcher.test.AbstractWatcherIntegrationTestCase; | ||
| import org.elasticsearch.xpack.watcher.transform.script.WatcherTransformScript; |
There was a problem hiding this comment.
It looks like the WatcherConditionScript and WatcherTransformScript classes are missing from this PR.
There was a problem hiding this comment.
Oops, this change was for a different PR (that depends on this on).
There was a problem hiding this comment.
I pushed ebe9b49 to remove it.
|
@elasticmachine run the java11 tests |
rjernst
added a commit
that referenced
this pull request
Sep 27, 2018
This commit adds the ability to plug in compilation of custom contexts in mock script engine. This is needed for testing plugins which add custom contexts like watcher.
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
This commit adds the ability to plug in compilation of custom contexts in mock script engine. This is needed for testing plugins which add custom contexts like watcher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the ability to plug in compilation of custom contexts
in mock script engine. This is needed for testing plugins which add
custom contexts like watcher.