Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more precise does S3 bucket exist method #34123

Merged
merged 2 commits into from
Sep 28, 2018
Merged

Use more precise does S3 bucket exist method #34123

merged 2 commits into from
Sep 28, 2018

Commits on Sep 27, 2018

  1. Use more precise does S3 bucket exist method 

    We are using a deprecated method for checking if an S3 bucket
exists. This deprecated method has a limitation that it can not
distinguish between invalid credentials and a lack of permissions. This
commit switches to using a method that correctly surfaces if invalid
credentials are supplied when checking for the existence of a bucket.
    @jasontedor
    jasontedor committed Sep 27, 2018
    Configuration menu
    Copy the full SHA
    9986ddb View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2018

  1. Use head request

    @jasontedor
    jasontedor committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    4376c7e View commit details
    Browse the repository at this point in the history