Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fix unit test deadlock problem #34174

Merged
merged 1 commit into from
Oct 1, 2018

Conversation

droberts195
Copy link
Contributor

This change fixes a potential deadlock problem in the unit
test introduced in #34117.

It also removes a piece of debug code and corrects a docs
formatting problem that were both added in that same PR.

This change fixes a potential deadlock problem in the unit
test introduced in elastic#34117.

It also removes a piece of debug code and corrects a docs
formatting problem that were both added in that same PR.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@droberts195
Copy link
Contributor Author

Marked as >non-issue as it's effectively part of #34117.

Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@droberts195 droberts195 merged commit a1d2ded into elastic:master Oct 1, 2018
@droberts195 droberts195 deleted the fix_test_deadlock branch October 1, 2018 14:35
droberts195 added a commit that referenced this pull request Oct 1, 2018
This change fixes a potential deadlock problem in the unit
test introduced in #34117.

It also removes a piece of debug code and corrects a docs
formatting problem that were both added in that same PR.
kcm pushed a commit that referenced this pull request Oct 30, 2018
This change fixes a potential deadlock problem in the unit
test introduced in #34117.

It also removes a piece of debug code and corrects a docs
formatting problem that were both added in that same PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants