-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stop rollup job support to HL REST Client #34702
Conversation
This change adds support for stoping a rollup job to the High Level REST Client. Relates to elastic#29827
96a3e46
to
ce3bc14
Compare
Pinging @elastic/es-search-aggs |
@elasticmachine test this please |
ba0b58b
to
0bab324
Compare
Rollup stuff LGTM. The client stuff does too, but I'll let @hub-cap cover that if he wants :) Aside and unrelated to this PR: we should probably adjust |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super minor nits
client/rest-high-level/src/main/java/org/elasticsearch/client/RollupRequestConverters.java
Outdated
Show resolved
Hide resolved
client/rest-high-level/src/main/java/org/elasticsearch/client/RollupRequestConverters.java
Outdated
Show resolved
Hide resolved
client/rest-high-level/src/main/java/org/elasticsearch/client/RollupRequestConverters.java
Outdated
Show resolved
Hide resolved
client/rest-high-level/src/test/java/org/elasticsearch/client/RollupRequestConvertersTests.java
Outdated
Show resolved
Hide resolved
@hub-cap thanks for the review, I pushed another commit adressing your comments and am waiting on the green light from CI now. |
@elasticmachine test this please |
This change adds support for stoping a rollup job to the High Level REST Client. Relates to #29827
This change adds support for stoping a rollup job to the High Level REST Client.
Relates to #29827