Delete flaky SettingsBasedHostProviderIT test #34813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveCTurner
added
>test
|
Pinging @elastic/es-distributed |
testClusterFormsByScanningPorts is flaky: sometimes in CI it's not possible to bind to any of the ports we need to in order for the port scanning to work. This change removes this test, and elastic#34809 describes a better way to test this behaviour.
DaveCTurner
force-pushed
the
2018-10-24-remove-bogus-discovery-test
branch
from
bcbbaa0
to
dce0041
Compare
DaveCTurner
added a commit
that referenced
this pull request
Oct 26, 2018
testClusterFormsByScanningPorts is flaky: sometimes in CI it's not possible to bind to any of the ports we need to in order for the port scanning to work. This change removes this test, and #34809 describes a better way to test this behaviour.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Oct 26, 2018
* 'master' of github.com:elastic/elasticsearch: Fix line length for org.elasticsearch.common.* files (elastic#34888) [ML] Extract common native process base class (elastic#34856) Refactor children aggregator into a generic ParentJoinAggregator (elastic#34845) [Style] Fix line lengths in action.admin.indices (elastic#34890) HLRC - add support for source exists API (elastic#34519) [CCR] Retry when no index shard stats can be found (elastic#34852) [Docs] audit logfile structured format (elastic#34584) [Test] Fix FullClusterRestartIT.testShrink() with copy_settings param (elastic#34853) Fix LineLength Check Suppressions: index.fielddata (elastic#34891) TEST: Stablize Minio Free Port Search (elastic#34894) Delete flaky SettingsBasedHostProviderIT test (elastic#34813) [ML] Include message in field_stats for text log files (elastic#34861) [TEST] HLRC: Expand failure messages in API checks (elastic#34838) Lowercase static final DeprecationLogger instance names (elastic#34887)
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
testClusterFormsByScanningPorts is flaky: sometimes in CI it's not possible to bind to any of the ports we need to in order for the port scanning to work. This change removes this test, and #34809 describes a better way to test this behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testClusterFormsByScanningPortsis flaky: sometimes in CI it's not possible tobind to any of the ports we need to in order for the port scanning to work.
This change removes this test, and #34809 describes a better way to test this
behaviour.