SQL: Provide null-safe scripts for Not and Neg #34877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce null-safe Painless scripts for Not and Neg Simplify script generation for Unary functions Close elastic#34848
|
Pinging @elastic/es-search-aggs |
astefan
approved these changes
Oct 26, 2018
| @@ -456,6 +456,13 @@ selectHireDateGroupByHireDate | |||
| SELECT hire_date HD, COUNT(*) c FROM test_emp GROUP BY hire_date ORDER BY hire_date DESC; | |||
| selectSalaryGroupBySalary | |||
| SELECT salary, COUNT(*) c FROM test_emp GROUP BY salary ORDER BY salary DESC; | |||
| selectSalaryGroupBySalaryHavingIsNotNull | |||
| SELECT salary, COUNT(*) c FROM test_emp GROUP BY salary HAVING MAX(languages) IS NOT NULL ORDER BY salary DESC; | |||
There was a problem hiding this comment.
This is a good test atm, but not really testing the behavior as MAX() doesn't seem to return null in any scenario #34896
There was a problem hiding this comment.
Good catch - due the use of primitives, a non-null value is returned all the time.
matriv
approved these changes
Oct 26, 2018
| } | ||
|
|
||
| if (!(input instanceof Boolean)) { | ||
| throw new SqlIllegalArgumentException("A boolean is required; received {}", input); |
There was a problem hiding this comment.
Shouldn't this already be caught by the pipeline? Is it just a "safety net" ?
There was a problem hiding this comment.
It is yes - we might not need them long term.
costin
added a commit
that referenced
this pull request
Oct 26, 2018
jasontedor
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Oct 26, 2018
* master: Introduce cross-cluster replication API docs (elastic#34726) Responses can use Writeable.Reader interface (elastic#34655) SQL: Provide null-safe scripts for Not and Neg (elastic#34877) Fix put/resume follow request parsing (elastic#34913) Fix line length for org.elasticsearch.common.* files (elastic#34888) [ML] Extract common native process base class (elastic#34856) Refactor children aggregator into a generic ParentJoinAggregator (elastic#34845) [Style] Fix line lengths in action.admin.indices (elastic#34890) HLRC - add support for source exists API (elastic#34519)
costin
added a commit
that referenced
this pull request
Oct 28, 2018
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
Introduce null-safe Painless scripts for Not and Neg Simplify script generation for Unary functions Close #34848
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce null-safe Painless scripts for Not and Neg
Simplify script generation for Unary functions
Close #34848