Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove include_type_name from the relevant APIs. #35192

Merged
merged 1 commit into from
Nov 6, 2018

Conversation

jtibshirani
Copy link
Contributor

We've decided that the bulk, delete, get, index, update, and search APIs should not contain this request parameter, and we will instead accept both typed and typeless calls.

@jtibshirani jtibshirani added WIP :Search Foundations/Mapping Index mappings, including merging and defining field types labels Nov 2, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@jtibshirani jtibshirani force-pushed the remove-parameter branch 2 times, most recently from f786bc5 to c99cfd0 Compare November 2, 2018 22:49
We've decided that the bulk, delete, get, index, update, and search APIs should not
contain this request parameter, and we will instead accept both typed and typeless calls.
@jtibshirani
Copy link
Contributor Author

@elasticmachine test this please

Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only looked at a subset of the test changes, but the main code changes look good to me, at least wrt. to the goal of the PR that you mentioned in the descrption. Not sure if other follow-up discussion need to happen, but the change by itself is good I think.

@jtibshirani
Copy link
Contributor Author

jtibshirani commented Nov 6, 2018

Thanks @cbuescher for taking a look. We've agreed on this point, and are tracking the overall plan to types deprecation here: #35190

@jtibshirani
Copy link
Contributor Author

CC @elastic/es-clients

@jtibshirani jtibshirani merged commit ec53288 into elastic:master Nov 6, 2018
@jtibshirani jtibshirani deleted the remove-parameter branch November 6, 2018 22:33
pgomulka pushed a commit to pgomulka/elasticsearch that referenced this pull request Nov 13, 2018
We've decided that the bulk, delete, get, index, update, and search APIs should not
contain this request parameter, and we will instead accept both typed and typeless calls.
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>non-issue :Search Foundations/Mapping Index mappings, including merging and defining field types v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants