Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HLRC][ML] Add ML find file structure API #35833

Merged
merged 2 commits into from
Nov 23, 2018

Conversation

droberts195
Copy link
Contributor

Relates to #29827

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

Copy link
Contributor

@edsavage edsavage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just one question

private final List<String> jodaTimestampFormats;
private final List<String> javaTimestampFormats;
private final String timestampField;
private final boolean needClientTimezone;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be Boolean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boolean matches the server side. This one is boolean rather than Boolean because it's always present in the output. The other flags are sometimes not set at all.

@droberts195 droberts195 merged commit 3c059ee into elastic:master Nov 23, 2018
@droberts195 droberts195 deleted the hlrc_find_file_structure branch November 23, 2018 06:58
droberts195 added a commit that referenced this pull request Nov 23, 2018
original-brownbear pushed a commit that referenced this pull request Nov 23, 2018
@tomcallahan tomcallahan removed the :ml Machine learning label Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants