-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HLRC][ML] Add ML find file structure API #35833
[HLRC][ML] Add ML find file structure API #35833
Conversation
Pinging @elastic/ml-core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just one question
private final List<String> jodaTimestampFormats; | ||
private final List<String> javaTimestampFormats; | ||
private final String timestampField; | ||
private final boolean needClientTimezone; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be Boolean
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
boolean
matches the server side. This one is boolean
rather than Boolean
because it's always present in the output. The other flags are sometimes not set at all.
Relates to #29827