Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get certificates HLRC API #36198

Merged
merged 2 commits into from
Dec 6, 2018
Merged

Fix get certificates HLRC API #36198

merged 2 commits into from
Dec 6, 2018

Conversation

jkakavas
Copy link
Member

@jkakavas jkakavas commented Dec 4, 2018

  • GetSslCertificatesRequest need not implement toXContentObject
  • getRequest() returns a new Request object
  • Add tests for GetSslCertificatesResponse
  • Adjust docs to the new format

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

albertzaharovits
albertzaharovits approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@albertzaharovits albertzaharovits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkakavas jkakavas merged commit 77e6ef7 into elastic:master Dec 6, 2018
jkakavas added a commit that referenced this pull request Dec 6, 2018
@jkakavas
Fix get certificates HLRC API (#36198)
a8d6234 
- GetSslCertificatesRequest need not implement toXContentObject
- getRequest() returns a new Request object
- Add tests for GetSslCertificatesResponse
- Adjust docs to the new format
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Dec 6, 2018
@jasontedor
Merge branch 'master' into build-docker-images
859a87f 
* master: (133 commits)
  SNAPSHOT: Increase Timeout to Stabilize Test (elastic#36294)
  Fix get certificates HLRC API (elastic#36198)
  Avoid shutting down the only master (elastic#36272)
  Fix typo in comment
  Fix total hits serialization of the search response (elastic#36290)
  Fix FullClusterRestartIT#testRollupIDSchemeAfterRestart
  Mute FullClusterRestartIT#testRollupIDSchemeAfterRestart as we await a fix.
  [Docs] Add Profile API limitations (elastic#36252)
  Make sure test don't use Math.random for reproducability (elastic#36241)
  Fix compilation
  ingest: support default pipeline through an alias (elastic#36231)
  Zen2: Rename tombstones to exclusions (elastic#36226)
  [Zen2] Hide not recovered state (elastic#36224)
  Test: mute testDataNodeRestartWithBusyMasterDuringSnapshot
  Test: mute testSnapshotAndRestoreWithNested
  Revert "Test: mute failing mtermvector rest test"
  Test: mute failing mtermvector rest test
  add version 6.5.3 (elastic#36268)
  Make hits.total an object in the search response (elastic#35849)
  [DOCS] Fixes broken link in execute watch
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertzaharovits albertzaharovits albertzaharovits approved these changes

Assignees
No one assigned
Labels
>non-issue v6.6.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jkakavas @elasticmachine @albertzaharovits @colings86