Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding additional tests for agg parsing in datafeedconfig #36261

Merged
merged 5 commits into from
Dec 6, 2018

Conversation

benwtrent
Copy link
Member

This adds additional serialization tests and addresses the strange parsing issue for lazily parsing aggregations.

closes #36250

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@benwtrent benwtrent removed the WIP label Dec 5, 2018
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benwtrent
Copy link
Member Author

jenkins retest this please

@benwtrent
Copy link
Member Author

run gradle build tests 2

@benwtrent benwtrent merged commit adc8355 into elastic:master Dec 6, 2018
@benwtrent benwtrent deleted the feature/bug-fix-for-agg-parsing branch December 6, 2018 17:19
benwtrent added a commit that referenced this pull request Dec 6, 2018
* Adding additional tests for agg parsing in datafeedconfig

* Fixing bug, adding yml test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Cannot create datafeed that uses aggs
4 participants