[Tests] Fix third party tests with Gradle 5.0 #36302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>test
|
Pinging @elastic/es-distributed |
ywelsch
approved these changes
Dec 6, 2018
| s3EC2BasePath = 'integration_test' | ||
| s3ECSBucket = 'ecs-bucket-test' | ||
| s3ECSBasePath = 'integration_test' | ||
| } |
There was a problem hiding this comment.
should we throw an exception as well if only a subset of the options are present?
|
Thanks @ywelsch |
tlrx
added a commit
that referenced
this pull request
Dec 6, 2018
This pull request fixes the build.gradle file so that it works with the Gradle 5.0 update (#34263). It also makes use of the ignore: 404 header in REST tests so that previous snapshots are deleted as part of the test set up. This way each new test run with an external service should start with a fresh repository even if the previous test run failed and left snapshots in the repo. (This is a best effort as it does not fix a corrupted repository)
tlrx
added a commit
that referenced
this pull request
Dec 6, 2018
This pull request fixes the build.gradle file so that it works with the Gradle 5.0 update (#34263). It also makes use of the ignore: 404 header in REST tests so that previous snapshots are deleted as part of the test set up. This way each new test run with an external service should start with a fresh repository even if the previous test run failed and left snapshots in the repo. (This is a best effort as it does not fix a corrupted repository)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the
build.gradlefile so that it works with the Gradle 5.0 update (#34263).It also makes use of the
ignore: 404header in REST tests so that previous snapshots are deleted as part of the test set up. This way each new test run with an external service should start with a fresh repository even if the previous test run failed and left snapshots in the repo. (This is a best effort as it does not fix a corrupted repository)