Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalidate Token API enhancements - HLRC #36362

Merged
merged 7 commits into from
Dec 18, 2018
Merged

Invalidate Token API enhancements - HLRC #36362

merged 7 commits into from
Dec 18, 2018

Conversation

jkakavas
Copy link
Member

@jkakavas jkakavas commented Dec 7, 2018

Adds Invalidate Token API enhancements to HLRC

Depends on: #35388

@jkakavas jkakavas added >enhancement v7.0.0 :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) v6.6.0 labels Dec 7, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

@jkakavas jkakavas mentioned this pull request Dec 7, 2018
Merged
@jkakavas
Copy link
Member Author

jkakavas commented Dec 7, 2018

This will keep on failing until #35388 is merged but I think it can be reviewed nevertheless, I'll ensure CI deities are satisfied before merging.

@tvernum tvernum changed the title Incalidate Token API enhancements - HLRC Invalidate Token API enhancements - HLRC Dec 10, 2018
@tvernum
Copy link
Contributor

tvernum commented Dec 10, 2018

Adds Invalidate Token API enhancements to HLRC

and rest tests & API docs

tvernum
tvernum approved these changes Dec 10, 2018
View reviewed changes
Copy link
Contributor

@tvernum tvernum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jkakavas
Copy link
Member Author 

10:24:21  [6.5.4] * What went wrong:
10:24:21  [6.5.4] Could not resolve all files for configuration ':server:compileClasspath'.
10:24:21  [6.5.4] > Could not download t-digest.jar (com.tdunning:t-digest:3.2)
10:24:21  [6.5.4]    > Could not get resource 'https://jcenter.bintray.com/com/tdunning/t-digest/3.2/t-digest-3.2.jar'.
10:24:21  [6.5.4]       > Could not HEAD 'https://jcenter.bintray.com/com/tdunning/t-digest/3.2/t-digest-3.2.jar'. Received status code 504 from server: Gateway Time-out

@jkakavas
Copy link
Member Author

@elasticmachine test this please

@jkakavas
Copy link
Member Author 


> Task :distribution:bwc:bugfix:buildBwcVersion
 [6.5.4] Found locally available resource with matching checksum: [https://jcenter.bintray.com/com/netflix/nebula/nebula-publishing-plugin/4.4.4/nebula-publishing-plugin-4.4.4.pom, /var/lib/jenkins/.gradle/caches/modules-2/files-2.1/com.netflix.nebula/nebula-publishing-plugin/4.4.4/5679184c34944ef53409e4a2f9e178446319b5f/nebula-publishing-plugin-4.4.4.pom]
 [6.5.4] Invalidating in-memory cache of /var/lib/jenkins/.gradle/caches/journal-1/file-access.bin
 [6.5.4] Failed to get resource: HEAD. [HTTP HTTP/1.1 504 Gateway Time-out: https://jcenter.bintray.com/com/github/jengelman/gradle/plugins/shadow/2.0.4/shadow-2.0.4.pom]
 [6.5.4] Failed to get resource: GET. [HTTP HTTP/1.1 504 Gateway Time-out: https://jcenter.bintray.com/com/carrotsearch/randomizedtesting/randomizedtesting-runner/2.7.0/randomizedtesting-runner-2.7.0.pom]
 [6.5.4] Failed to get resource: HEAD. [HTTP HTTP/1.1 504 Gateway Time-out: https://jcenter.bintray.com/de/thetaphi/forbiddenapis/2.6/forbiddenapis-2.6.pom]
 [6.5.4] 
 [6.5.4] FAILURE: Build failed with an exception.

:(

@elasticmachine run the gradle build tests 2

@jkakavas jkakavas merged commit 78f9af1 into elastic:master Dec 18, 2018
jkakavas added a commit to jkakavas/elasticsearch that referenced this pull request Dec 18, 2018
@jkakavas
Invalidate Token API enhancements - HLRC (elastic#36362)
a114e0b 
* Adds Invalidate Token API enhancements to HLRC

Relates: elastic#35388
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Dec 18, 2018
@jasontedor
Merge remote-tracking branch 'elastic/master' into lazier-ingest-geoip
a674600 
* elastic/master: (31 commits)
  enable bwc tests and switch transport serialization version to 6.6.0 for CAS features
  [DOCs] Adds ml-cpp PRs to alpha release notes (elastic#36790)
  Synchronize WriteReplicaResult callbacks (elastic#36770)
  Add CcrRestoreSourceService to track sessions (elastic#36578)
  [Painless] Add tests for boxed return types (elastic#36747)
  Internal: Remove originalSettings from Node (elastic#36569)
  [ILM][DOCS] Update ILM API authorization docs (elastic#36749)
  Core: Deprecate use of scientific notation in epoch time parsing (elastic#36691)
  [ML] Merge the Jindex master feature branch (elastic#36702)
  Tests: Mute SnapshotDisruptionIT.testDisruptionOnSnapshotInitialization
  Update versions in SearchSortValues transport serialization
  Update version in SearchHits transport serialization
  [Geo] Integrate Lucene's LatLonShape (BKD Backed GeoShapes) as default `geo_shape` indexing approach (elastic#36751)
  [Docs] Fix error in Common Grams Token Filter (elastic#36774)
  Fix rollup search statistics (elastic#36674)
  SQL: Fix wrong appliance of StackOverflow limit for IN (elastic#36724)
  [TEST] Added more logging
  Invalidate Token API enhancements - HLRC (elastic#36362)
  Deprecate types in index API (elastic#36575)
  Disable bwc tests until elastic#36555 backport is complete (elastic#36737)
  ...
jkakavas added a commit that referenced this pull request Dec 18, 2018
@jkakavas
Invalidate Token API enhancements - HLRC (#36362) (#36787)
f60546b 
* Adds Invalidate Token API enhancements to HLRC

Relates: #35388
jkakavas added a commit that referenced this pull request Dec 20, 2018
@jkakavas
Unmute SecurityDocumentationIT test
45a9756 
Since #36362 is merged
the invalidateTokensTest for the HLRC can be run again.
jkakavas added a commit that referenced this pull request Dec 20, 2018
@jkakavas
Unmute SecurityDocumentationIT test
24063a1 
Since #36362 is merged
the invalidateTokensTest for the HLRC can be run again.
@jkakavas jkakavas mentioned this pull request Jan 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvernum tvernum tvernum approved these changes

@albertzaharovits albertzaharovits Awaiting requested review from albertzaharovits

Assignees
No one assigned
Labels
>enhancement :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) v6.6.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jkakavas @elasticmachine @tvernum @colings86