Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update transport docs and settings for changes #36913

Merged
merged 2 commits into from
Dec 20, 2018
Merged

Update transport docs and settings for changes #36913

merged 2 commits into from
Dec 20, 2018

Commits on Dec 20, 2018

  1. Update transport docs and settings for changes (elastic#36786) 

    This is related to elastic#36652. In 7.0 we plan to deprecate a number of
settings that make reference to the concept of a tcp transport. We
mostly just have a single transport type now (based on tcp). Settings
should only reference tcp if they are referring to socket options. This
commit updates the settings in the docs. And removes string usages of
the old settings. Additionally it adds a missing remote compress setting
to the docs.
    @Tim-Brooks
    Tim-Brooks committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    e862ef9 View commit details
    Browse the repository at this point in the history

  2. Revert transport.port change for tests (elastic#36809) 

    Commit elastic#36786 updated docs and strings to reference transport.port instead of
transport.tcp.port. However, this breaks backwards compatibility tests
as the tests rely on string configurations and transport.port does not
exist prior to 6.6. This commit reverts the places were we reference
transport.tcp.port for tests. This work will need to be reintroduced in
a backwards compatible way.
    @Tim-Brooks
    Tim-Brooks committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    48714af View commit details
    Browse the repository at this point in the history