Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing parameter add #37294

Closed
wants to merge 1 commit into from
Closed

Missing parameter add #37294

wants to merge 1 commit into from

Conversation

jm4ever
Copy link

@jm4ever jm4ever commented Jan 10, 2019

bin/elasticsearch-keystore add xpack.notification.email.account.gmail_account.smtp.secure_password
bin/elasticsearch-keystore add xpack.notification.email.account.outlook_account.smtp.secure_password
bin/elasticsearch-keystore add xpack.notification.email.account.ses_account.smtp.secure_password
bin/elasticsearch-keystore add xpack.notification.email.account.exchange_account.smtp.secure_password

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS that we support?
  • If you are submitting this code for a class then read our policy for that.

@jm4ever
Missing parameter add
7aebe72 
bin/elasticsearch-keystore add xpack.notification.email.account.gmail_account.smtp.secure_password
bin/elasticsearch-keystore add xpack.notification.email.account.outlook_account.smtp.secure_password
bin/elasticsearch-keystore xpack.notification.email.account.ses_account.smtp.secure_password
bin/elasticsearch-keystore add xpack.notification.email.account.exchange_account.smtp.secure_password
@cbuescher cbuescher added >docs General docs changes :Security/Security Security issues without another label labels Jan 10, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

@cbuescher cbuescher added :Data Management/Watcher and removed :Security/Security Security issues without another label labels Jan 10, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

jakelandis
jakelandis requested changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@jakelandis jakelandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jm4ever - thanks for the contribution. Can you please sign the CLA and re-target your PR to master ? (I will back port to released versions)

@jrodewig
Copy link
Contributor

jrodewig commented Oct 18, 2019 •
edited
Loading

CLA not signed. #40417 and #40444 corrected these bugs in later branches.

@jrodewig jrodewig closed this Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelandis jakelandis jakelandis requested changes

Assignees
No one assigned
Labels
:Data Management/Watcher >docs General docs changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jm4ever @elasticmachine @jrodewig @jakelandis @cbuescher