Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate unused Zen1 settings #38289

Merged

Conversation

DaveCTurner
Copy link
Contributor

Today the following settings in the discovery.zen namespace are still used:

  • discovery.zen.no_master_block
  • discovery.zen.hosts_provider
  • discovery.zen.ping.unicast.concurrent_connects
  • discovery.zen.ping.unicast.hosts.resolve_timeout
  • discovery.zen.ping.unicast.hosts

This commit deprecates all other settings in this namespace so that they can be
removed in the next major version.

Today the following settings in the `discovery.zen` namespace are still used:

- `discovery.zen.no_master_block`
- `discovery.zen.hosts_provider`
- `discovery.zen.ping.unicast.concurrent_connects`
- `discovery.zen.ping.unicast.hosts.resolve_timeout`
- `discovery.zen.ping.unicast.hosts`

This commit deprecates all other settings in this namespace so that they can be
removed in the next major version.
@DaveCTurner DaveCTurner added >non-issue v7.0.0 :Distributed/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. labels Feb 3, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@ywelsch ywelsch mentioned this pull request Feb 3, 2019
61 tasks
Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. In a follow-up, let's add new settings for these remaining ones in a different namespace, deprecate these 5 and default the new ones to the deprecated ones.

@DaveCTurner DaveCTurner merged commit 1d82a6d into elastic:master Feb 4, 2019
@DaveCTurner DaveCTurner deleted the 2019-02-03-deprecate-zen-settings branch February 4, 2019 08:52
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Oct 7, 2021
Zen discovery and its associated settings were deprecated in 7.0. This
commit adds an entry to the release notes calling this out.

Relates elastic#38289 elastic#38333 elastic#38350 elastic#37868
DaveCTurner added a commit that referenced this pull request Oct 7, 2021
Zen discovery and its associated settings were deprecated in 7.0. This
commit adds an entry to the release notes calling this out.

Relates #38289 #38333 #38350 #37868
DaveCTurner added a commit that referenced this pull request Oct 10, 2021
Zen discovery and its associated settings were deprecated in 7.0. This
commit adds an entry to the release notes calling this out.

Relates #38289 #38333 #38350 #37868
DaveCTurner added a commit that referenced this pull request Oct 10, 2021
Zen discovery and its associated settings were deprecated in 7.0. This
commit adds an entry to the release notes calling this out.

Relates #38289 #38333 #38350 #37868
DaveCTurner added a commit that referenced this pull request Oct 10, 2021
Zen discovery and its associated settings were deprecated in 7.0. This
commit adds an entry to the release notes calling this out.

Relates #38289 #38333 #38350 #37868
DaveCTurner added a commit that referenced this pull request Oct 10, 2021
Zen discovery and its associated settings were deprecated in 7.0. This
commit adds an entry to the release notes calling this out.

Relates #38289 #38333 #38350 #37868
DaveCTurner added a commit that referenced this pull request Oct 10, 2021
Zen discovery and its associated settings were deprecated in 7.0. This
commit adds an entry to the release notes calling this out.

Relates #38289 #38333 #38350 #37868
DaveCTurner added a commit that referenced this pull request Oct 10, 2021
Zen discovery and its associated settings were deprecated in 7.0. This
commit adds an entry to the release notes calling this out.

Relates #38289 #38333 #38350 #37868
DaveCTurner added a commit that referenced this pull request Oct 10, 2021
Zen discovery and its associated settings were deprecated in 7.0. This
commit adds an entry to the release notes calling this out.

Relates #38289 #38333 #38350 #37868
DaveCTurner added a commit that referenced this pull request Oct 10, 2021
Zen discovery and its associated settings were deprecated in 7.0. This
commit adds an entry to the release notes calling this out.

Relates #38289 #38333 #38350 #37868
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. >non-issue v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants