Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not recommend installing vagrant-winrm #38887

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Do not recommend installing vagrant-winrm #38887

merged 1 commit into from
Feb 14, 2019

Conversation

pgomulka
Copy link
Contributor

@pgomulka pgomulka commented Feb 14, 2019 •
edited
Loading

I am getting a warning that vagrant winrm plugin is no longer required as it is shipped with vagrant. Removing the suggestion from TESTING.asciidoc to have it

WARNING: Vagrant has detected the `vagrant-winrm` plugin. Vagrant ships with
WinRM support builtin and no longer requires the `vagrant-winrm` plugin. To
prevent unexpected errors please uninstall the `vagrant-winrm` plugin using
the command shown below:

  vagrant plugin uninstall vagrant-winrm

my vagrant version

vagrant --version
Vagrant 2.1.4

plugins version I had

ninstalling the 'vagrant-winrm' plugin...
Successfully uninstalled vagrant-winrm-0.7.0
Successfully uninstalled minitar-0.8

@pgomulka pgomulka added the >docs General docs changes label Feb 14, 2019
@pgomulka pgomulka changed the title remove the winrm section Do not recommend installing vagrant-winrm Feb 14, 2019
jasontedor
jasontedor approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pgomulka pgomulka merged commit 0bc1896 into elastic:master Feb 14, 2019
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 14, 2019
@jasontedor
Merge remote-tracking branch 'elastic/master' into retention-lease-ccr
b8b2537 
* elastic/master:
  Remove immediate operation retry after mapping update (elastic#38873)
  Remove mentioning of types from bulk API docs (elastic#38896)
  SQL: change JDBC setup URL in the documentation (elastic#38564)
  Skip BWC tests in checkPart1 and checkPart2 (elastic#38730)
  Enable silent FollowersCheckerTest (elastic#38851)
  Update TESTING.asciidoc with platform specific instructions (elastic#38802)
  Use consistent view of realms for authentication (elastic#38815)
  Stabilize RareClusterState (elastic#38671)
  Increase Timeout in UnicastZenPingTests (elastic#38893)
  Do not recommend installing vagrant-winrm elastic#38887
  _cat/indices with Security, hide names when wildcard (elastic#38824)
  SQL: fall back to using the field name for column label (elastic#38842)
  Fix LocalIndexFollowingIT#testRemoveRemoteConnection() test (elastic#38709)
  Remove joda time mentions in documentation (elastic#38720)
  Add enabled status for token and api key service (elastic#38687)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasontedor jasontedor jasontedor approved these changes

Assignees
No one assigned
Labels
>docs General docs changes >non-issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pgomulka @jasontedor