Deprecate types in _graph/explore calls.
#40466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any call that uses a path that sets a type will trigger a deprecation warning.
|
Pinging @elastic/es-analytics-geo |
jtibshirani
approved these changes
Mar 26, 2019
There was a problem hiding this comment.
Thanks @jpountz for handling this.
I also think we should mark the HLRC GraphExploreRequest#types method as deprecated. Other than that it looks good to me.
jpountz
added a commit
to jpountz/elasticsearch
that referenced
this pull request
Mar 27, 2019
Any call that uses a path that sets a type will trigger a deprecation warning.
jpountz
added a commit
to jpountz/elasticsearch
that referenced
this pull request
Mar 27, 2019
Any call that uses a path that sets a type will trigger a deprecation warning.
jpountz
added a commit
that referenced
this pull request
Mar 28, 2019
Any call that uses a path that sets a type will trigger a deprecation warning.
48 tasks
jpountz
added a commit
that referenced
this pull request
Mar 28, 2019
Any call that uses a path that sets a type will trigger a deprecation warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any call that uses a path that sets a type will trigger a deprecation warning.