Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds data frame analytics APIs to the ML APIs #43875

Merged
merged 13 commits into from
Jul 5, 2019

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Jul 2, 2019

This PR adds the reference documentation pages of the data frame analytics APIs (PUT, START, STOP, GET, GET stats, DELETE, Evaluate) to the ML APIs pool.

This PR depends on elastic/docs#963, which adds new shared attributes.

@szabosteve szabosteve added :ml Machine learning :ml/Transform Transform >docs General docs changes v7.3.0 v8.0.0 labels Jul 2, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@szabosteve szabosteve marked this pull request as ready for review July 3, 2019 08:44
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few minor points.

docs/reference/ml/apis/put-dfanalytics.asciidoc Outdated Show resolved Hide resolved
docs/reference/ml/apis/put-dfanalytics.asciidoc Outdated Show resolved Hide resolved
docs/reference/ml/apis/put-dfanalytics.asciidoc Outdated Show resolved Hide resolved
docs/reference/ml/apis/put-dfanalytics.asciidoc Outdated Show resolved Hide resolved
@jpountz jpountz added v7.4.0 and removed v7.3.0 labels Jul 3, 2019
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl
Copy link
Contributor

lcawl commented Jul 4, 2019

@dimitris-athanasiou While wrestling with the gradle checks, I found that there were some extra fields in the results (e.g. version and create_time). Can you confirm that the changes in 0454112 are appropriate?

@dimitris-athanasiou
Copy link
Contributor

@lcawl Yes, sorry, those two - version and create_time - are populated when a job is created. The changes looks good.

@szabosteve szabosteve merged commit cccf5ba into elastic:master Jul 5, 2019
@szabosteve szabosteve deleted the dfaapis branch July 5, 2019 11:34
szabosteve added a commit that referenced this pull request Jul 5, 2019
This PR adds the reference documentation pages of the data frame analytics APIs (PUT, START, STOP, GET, GET stats, DELETE, Evaluate) to the ML APIs pool.
szabosteve added a commit that referenced this pull request Jul 5, 2019
This PR adds the reference documentation pages of the data frame analytics APIs (PUT, START, STOP, GET, GET stats, DELETE, Evaluate) to the ML APIs pool.
@droberts195 droberts195 removed the :ml/Transform Transform label Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :ml Machine learning v7.3.0 v7.4.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants