Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Reformat refresh API docs #46667

Merged
merged 3 commits into from
Oct 4, 2019
Merged

[DOCS] Reformat refresh API docs #46667

merged 3 commits into from
Oct 4, 2019

Conversation

jrodewig
Copy link
Contributor

Changes

Relates to #43765.

@jrodewig jrodewig added >docs General docs changes :Data Management/Indices APIs APIs to create and manage indices and templates v8.0.0 v7.3.0 v7.4.0 v7.5.0 labels Sep 12, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@jrodewig jrodewig requested review from jpountz and jasontedor and removed request for jpountz September 25, 2019 20:10
@jrodewig jrodewig added v7.4.1 and removed v7.4.0 labels Sep 27, 2019
debadair
debadair approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

debadair
debadair approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jpountz
jpountz reviewed Oct 4, 2019
View reviewed changes
Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a suggestion to clarify a couple more points about refreshes.

docs/reference/indices/refresh.asciidoc Show resolved Hide resolved
@jrodewig jrodewig requested a review from jpountz October 4, 2019 13:51
jpountz
jpountz approved these changes Oct 4, 2019
View reviewed changes
docs/reference/indices/refresh.asciidoc Outdated Show resolved Hide resolved
@jrodewig jrodewig merged commit fbf698e into elastic:master Oct 4, 2019
@jrodewig jrodewig deleted the refresh-api-reformat branch October 4, 2019 16:16
This was referenced Oct 4, 2019
Merged
Merged
Merged
jrodewig added a commit that referenced this pull request Oct 4, 2019
@jrodewig
[DOCS] Reformat refresh API docs (#46667) (#47589)
0b4fb05
jrodewig added a commit that referenced this pull request Oct 4, 2019
@jrodewig
[DOCS] Reformat refresh API docs (#46667) (#47590)
cc0502f
jrodewig added a commit that referenced this pull request Oct 4, 2019
@jrodewig
[DOCS] Reformat refresh API docs (#46667) (#47591)
4389db9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpountz jpountz jpountz approved these changes

@debadair debadair debadair approved these changes

@jasontedor jasontedor Awaiting requested review from jasontedor

@szabosteve szabosteve Awaiting requested review from szabosteve

Assignees
No one assigned
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates >docs General docs changes v7.3.0 v7.4.1 v7.5.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jrodewig @elasticmachine @jpountz @debadair @jakelandis