SLM Start/Stop HLRC and docs #47966
Merged
SLM Start/Stop HLRC and docs #47966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds HLRC support and documentation for the SLM Start and Stop APIs, as well as updating existing documentation where appropriate.
gwbrown
added
:Data Management/ILM+SLM
|
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
dakrone
reviewed
Oct 14, 2019
client/rest-high-level/src/main/java/org/elasticsearch/client/IndexLifecycleClient.java
Outdated
Show resolved
Hide resolved
client/rest-high-level/src/main/java/org/elasticsearch/client/IndexLifecycleClient.java
Outdated
Show resolved
Hide resolved
client/rest-high-level/src/main/java/org/elasticsearch/client/IndexLifecycleClient.java
Outdated
Show resolved
Hide resolved
|
Thanks for the review @dakrone, I've addressed your comments and made several other changes, as the SLM HLRC docs were not actually included in the doc build - I'd appreciate a review of those changes as well. |
dakrone
approved these changes
Oct 14, 2019
| * @return the response | ||
| * @throws IOException in case there is a problem sending the request or parsing back the response | ||
| */ | ||
| public LifecycleManagementStatusResponse snapshotLifecycleManagementStatus(SnapshotLifecycleManagementStatusRequest request, |
There was a problem hiding this comment.
Something that occurs to me, should we rename these getSLMStatus to make them shorter? That's what the Action is named
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Oct 14, 2019
This commit adds HLRC support and documentation for the SLM Start and Stop APIs, as well as updating existing documentation where appropriate. This commit also ensures that the SLM APIs are properly included in the HLRC documentation.
gwbrown
added a commit
that referenced
this pull request
Oct 14, 2019
This commit adds HLRC support and documentation for the SLM Start and Stop APIs, as well as updating existing documentation where appropriate. This commit also ensures that the SLM APIs are properly included in the HLRC documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds HLRC support and documentation for the SLM Start and
Stop APIs, as well as updating existing documentation where appropriate.
Relates to #43663 and #47710