Move MinIO fixture in its own fixture project #48921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>test
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
tlrx
changed the title
There was a problem hiding this comment.
I think this needs an @atorok review :) All I can point out is that there's some merge conflict in the build file.
Probably from changing the default parameters for the S3 endpoint (I think you did that in some other PR as well a few days back)
|
@original-brownbear Just wanted you to be OK with moving this to a fixture :) And sorry for the conflicts, #48849 was merged 2 hours and I did not notice. |
|
@tlrx ah ok, thanks for checking -> I'm good with this if Alpar is :) |
|
@elasticmachine update branch |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Nov 13, 2019
This commit moves the MinIO docker-compose fixture from the :plugins:repository-s3 to its own :test:minio-fixture Gradle project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request moves the MinIO docker-compose fixture from the
:plugins:repository-s3to its own:test:minio-fixtureGradle project.The goal here is to make the fixture more easily reusable and also makes the
repository-s3build Gradle file a bit more comprehensive.