[DOCS] Correct percentile rank agg example responses #50052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrodewig
added
>docs
|
Pinging @elastic/es-docs (>docs) |
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
This was referenced Dec 10, 2019
The example snippets in the percentile rank agg docs use a test dataset named latency, which is generated from docs/gradle.build. At some point the dataset and example snippets were updated, but the text surrounding the snippets was not. This meant the text and the example snippets shown no longer match up. Because the surrounding text seemed more realistic, this changes the snippets to match using //TESTRESPONSE magic comments.
|
@elasticmachine update branch |
polyfractal
approved these changes
Dec 11, 2019
jrodewig
added a commit
that referenced
this pull request
Dec 12, 2019
The example snippets in the percentile rank agg docs use a test dataset named `latency`, which is generated from docs/gradle.build. At some point the dataset and example snippets were updated, but the text surrounding the snippets was not. This means the text and the example snippets shown no longer match up. This corrects that by changing the snippets using /TESTRESPONSE magic comments.
jrodewig
added a commit
that referenced
this pull request
Dec 12, 2019
The example snippets in the percentile rank agg docs use a test dataset named `latency`, which is generated from docs/gradle.build. At some point the dataset and example snippets were updated, but the text surrounding the snippets was not. This means the text and the example snippets shown no longer match up. This corrects that by changing the snippets using /TESTRESPONSE magic comments.
jrodewig
added a commit
that referenced
this pull request
Dec 12, 2019
The example snippets in the percentile rank agg docs use a test dataset named `latency`, which is generated from docs/gradle.build. At some point the dataset and example snippets were updated, but the text surrounding the snippets was not. This means the text and the example snippets shown no longer match up. This corrects that by changing the snippets using /TESTRESPONSE magic comments.
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
The example snippets in the percentile rank agg docs use a test dataset named `latency`, which is generated from docs/gradle.build. At some point the dataset and example snippets were updated, but the text surrounding the snippets was not. This means the text and the example snippets shown no longer match up. This corrects that by changing the snippets using /TESTRESPONSE magic comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example snippets in the percentile rank agg docs use a test dataset named
latency, which is generated from docs/gradle.build.At some point the dataset and example snippets were updated, but the text surrounding the snippets was not. This meant the text and the example snippets shown no longer match up.
Because the surrounding text seemed more realistic, this changes the snippets to match using //TESTRESPONSE magic comments.
Let me know if we prefer to create a new example dataset. This just seemed like a simpler, more straightforward solution.
Supersedes/closes #45069, #45985, #48121