Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard format for reload settings API (#51560) #51828

Conversation

williamrandolph
Copy link
Contributor

  • Use standard format for reload settings API

The reload-secure-settings API page was not reorganized for the standard
API format, so this commit is reorganizing the page and adding some
links to the page in related documentation.

  • Fix broken links

  • Reorder examples to correctly check API response

  • Note that only certain settings are reloadable

  • [DOCS] Edits layout

  • [DOCS] Removes unnecessary callouts

Co-authored-by: Lisa Cawley lcawley@elastic.co

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

* Use standard format for reload settings API

The reload-secure-settings API page was not reorganized for the standard
API format, so this commit is reorganizing the page and adding some
links to the page in related documentation.

* Fix broken links

* Reorder examples to correctly check API response

* Note that only certain settings are reloadable

* [DOCS] Edits layout

* [DOCS] Removes unnecessary callouts

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
@williamrandolph williamrandolph added >docs General docs changes >non-issue :Security/Security Security issues without another label backport labels Feb 3, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (:Security/Security)

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@williamrandolph williamrandolph merged commit ba2810f into elastic:7.x Feb 3, 2020
@williamrandolph williamrandolph deleted the backport/7.x/fix-reload-nodes-docs branch May 23, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport >docs General docs changes >non-issue :Security/Security Security issues without another label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants